Re: Patch to gnatsweb.pl to display the new PR #
Yngve Svendsen <[email protected]> Mon, 04 Sep 2006 14:23:53 +0200
| Newsgroups | gmane.comp.bug-tracking.gnats.general |
|---|---|
| Message-ID | <[email protected]> |
Thanks! I have committed a minimally modified version of this patch.
Better late than never...
Yngve Svendsen
Gnatsweb maintainer
Tim Buck wrote:
> Since GNATS now returns the newly-assigned PR number when a new PR
> is filed, I've made some changes to our gnatsweb.pl to use this
> information. This change will cause gnatsweb.pl to display a link to
> the newly-created PR in the submitnewpr feedback message.
>
> My revision numbers and line numbers are vastly different from
> those in the official repository, because we have made so many
> local revisions to gnatsweb -- my apologies for that.
>
> RCS file: /cvs/root/systems/gnu/gnatsweb/gnatsweb.pl,v
> retrieving revision 1.124
> diff -u -p -r1.124 gnatsweb.pl
> --- gnatsweb.pl 18 Mar 2005 15:11:02 -0000 1.124
> +++ gnatsweb.pl 23 Mar 2005 14:49:01 -0000
> @@ -1611,7 +1611,12 @@ EOT
> client_cmd("$text.");
>
> client_cmd ("subm");
> - client_cmd("$text.");
> + # Get returned new PR number
> + my $new_prnum = join(" ",client_cmd("$text.")) || '';
> + # Strip off extra space at the end
> + $new_prnum =~ s/([0-9]+).*/$1/;
> + # How about a URL pointing us to it?
> + my $new_pr_url = get_viewpr_url($new_prnum);
>
> my $return_url = $q->param('return_url') || get_script_name();
> my $refresh = 5;
> @@ -1631,11 +1636,10 @@ EOT
>
> # Give feedback for success
> page_heading($page, 'Problem Report Sent');
> - print "<p>Thank you for your report. It will take a short while for
> -your report to be processed. When it is, you will receive
> -an automated message about it, containing the Problem Report
> -number, and the developer who has been assigned to
> -investigate the problem.</p>";
> + print "<p>Thank you for your report. It has been assigned
> +<a href=\"$new_pr_url\">PR #$new_prnum</a>. You will receive an
> automated
> +message about it, containing the Problem Report number, and the
> developer who
> +has been assigned to investigate the problem.</p>\n";
> print "<p>You will be returned to <a href=\"$return_url\">your
> previous page</a>
> in $refresh seconds...</p>";
>
>
> Tim Buck * Information Technology Manager * Recognition Research, Inc.
> PHONE +1 540 961-6500 * FAX +1 540 961-3568 * EMAIL [email protected]
> No one ever went broke underestimating the intelligence of the
> American People -- P. T. Barnum
>
>
>
>
> _______________________________________________
> Help-gnats mailing list
> [email protected]
> http://lists.gnu.org/mailman/listinfo/help-gnats