gnatsweb/770: problem with duplicated "cmd" CGI variable. [PATCH]
Stephane Chazelas <[email protected]> Fri, 16 Nov 2007 14:56:19 +0000
| Newsgroups | gmane.comp.bug-tracking.gnats.general |
|---|---|
| Organization | Embedded Computing Emerson Network Power |
| Message-ID | <[email protected]> |
Hiya, I've submitted a new PR at http://gnats.wookimus.net/ for that issue. Please see http://gnats.wookimus.net/cgi-bin/gnatsweb.pl?user=guest&cmd=view&database=default&pr=770 for details. However, it seems that submissions to [email protected] don't work anymore, so that I can't add information to that PR. Hence this email to this list. Regarding that PR, here is a patch that fixes it for me. Not very neat as it relies a bit on the CGI perl module internals but short and effective: --- gnatsweb.pl.orig 2003-07-29 13:24:22.000000000 +0100 +++ gnatsweb.pl 2007-11-16 14:30:32.000000000 +0000 @@ -2579,8 +2579,6 @@ sub store_query exit(); } - # Don't save certain params. - $q->delete('cmd'); my $query_string = $q->query_string(); # strip empty params out of $query_string. in a gnats db with many @@ -4148,6 +4146,9 @@ sub main $script_name = $q->script_name; my $cmd = $q->param('cmd') || ''; # avoid perl -w warning + $q->delete('cmd'); + $ENV{'REQUEST_URI'} = $q->url(-absolute=>1,-query=>1); + ### Cookie-related code must happen before we print the HTML header. init_prefs(); Best regards, Stephane