gnats/615: Re: gnats/615: AF_INET6 causes compilation failure on Solaris 7

The following reply was made to PR gnats/615; it has been noted by GNATS.

From: Stephane Chazelas <[email protected]>
To: [email protected]
Cc: 
Subject: Re: gnats/615: AF_INET6 causes compilation failure on Solaris 7
Date: Fri, 16 Nov 2007 08:15:37 +0000

 On Tue, Jan 30, 2007 at 10:08:37AM +0000, Stephane Chazelas wrote:
 > Hi Chad,
 > 
 > sorry I haven't had the opportunity to try it yet, but looking
 > at the code, there would seem to be a problem:
 > 
 >       if ((s.sin_family != AF_INET)
 > #if defined(HAVE_DECL_AF_INET6) || defined(AF_INET6)
 >           /* AF_INET6 could be an enum or defined, if present */
 >           && (s.sin_family != AF_INET6))
 > #endif
 >       {
 > 
 > Looks like the outermost "(" is not matched in the no-INET6 case.
 > 
 > BTW, have you had a chance to give more thoughts to gnats/665?
 [...]
 
 Hi Chad,
 
 sorry it took me so long to eventually try it out on a Solaris
 box.
 
 There's another problem with that code above.
 
 HAVE_DECL_AF_INET6 is always defined, either to 0 or to 1. On my
 Solaris 7 machine, config.h contains:
 
 /* Define to 1 if you have the declaration of `AF_INET6', and to 0 if you
    don't. */
 #define HAVE_DECL_AF_INET6 0
 
 
 So it should be:
 
 #if HAVE_DECL_AF_INET6 || defined(AF_INET6)
 ...
 #endif /* IPv6 supported */
 
 
 Best regards,
 Stephane