Fw: Possible bug note ordering bug.

> Hi, I am playing with the number of
> bug notes emailed and the order in which they appear. I have
> found the following
> 
> $g_default_bugnote_order         
>       = 'DESC';
> $g_default_email_bugnote_limit       
>   = 2;
> 
> BUT the sort order does NOT apply to emails. I can not seem
> to change the order in which bugs appear in emails. Is this
> a bug? I really want to limit the number of notes emailed
> and have the new ones at the top.
> 
> Secondly these changes - although default no not seem to
> override an existing users settings even if that user has
> never changed them. Is only applied to new users/users that
> reset prefs. Is this desirable?
> 
> 

Hi all i am now quite confident this is a bug. i have been playing about with the emai_API.php and notice this call

$t_user_bugnote_order = user_pref_get_pref ( $p_user_id, 'bugnote_order' );

in function email_build_visible_bug_data

The value inserted into t_user_bugnote_order MUST be incorrect as when i hard code values of ASC or DESC as follows

$t_bug_data['bugnotes'] = bugnote_get_all_visible_bugnotes( $p_bug_id, $t_user_access_level, 'DESC', $t_user_bugnote_limit );

I get the desired effect - i.e. the bug note ordering in emails actually changes. 

Unfortunately I think I have hit my limit of testing as I dont know how to get debug output of out mantis. I am going to raise this as an issue.


      

------------------------------------------------------------------------------
Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT 
is a gathering of tech-side developers & brand creativity professionals. Meet
the minds behind Google Creative Lab, Visual Complexity, Processing, & 
iPhoneDevCamp as they present alongside digital heavyweights like Barbarian 
Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com