Re: [mantisbt-dev] MantisBT 1.2.0rc2 Release Candidate 2

Jeferson Oliveira <[email protected]>
Newsgroups gmane.comp.bug-tracking.mantis.general,gmane.comp.bug-tracking.mantis.devel,gmane.comp.bug-tracking.mantis.localization
Message-ID <[email protected]>
On Fri, Nov 27, 2009 at 12:27 PM, Jeferson Oliveira wrote:
> I have installed and configured the
> Mantis/WebSVN integration and less than 15 minutes.


I forgot to mention that I need to change the WebSVN path validation
("plugins/SourceWebSVN/pages/config_update.php" ) to work on Windows
instead of always return the error "Path to Subversion binary invalid
or inaccessible".

The test condition now looks like:

		# be sure that the path is valid
		if ( is_dir( $f_svnpath ) &&
			(is_file( $f_svnpath . DIRECTORY_SEPARATOR . 'svn' ) || is_file(
$f_svnpath . DIRECTORY_SEPARATOR . 'svn.exe' )) &&
			(is_executable( $f_svnpath . DIRECTORY_SEPARATOR . 'svn' ) ||
is_executable( $f_svnpath . DIRECTORY_SEPARATOR . 'svn.exe' ))) {

Maybe a variable to store the file name that test if PHP is running
over Windows (to append the .exe extension) could be a more elegant
way to fix this.

Hope this helps!

--
Regards,

Jeferson Oliveira
Brazil

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.