Re: Onetime CC are giving an internal error

Gordon Messmer <[email protected]> Thu, 16 Feb 2017 16:00:33 -0800
Newsgroups gmane.comp.bug-tracking.request-tracker.user
Message-ID <[email protected]>
This is a MIME-formatted message.  If you see this text it means that your
E-mail software does not support MIME-formatted messages.

--=_ascension.private.dragonsdawn.-19989-1487289637-0001-2
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

> We are running rt-4.4.0 and just noticed that selecting a One-time Cc
> gives an internal error in the Scrips and Recipients block.
> The error is:
>
> [9625] [Thu Apr  7 12:37:48 2016] [warning]: Use of uninitialized value in split at /opt/rt4/share/html/Helpers/PreviewScrips line 81. (/opt/rt4/share/html/Helpers/PreviewScrips:81)
> [9625] [Thu Apr  7 12:37:48 2016] [error]: Operation "eq": no method found,
>          left argument has no overloaded magic,
>          right argument in overloaded package Email::Address at /opt/rt4/share/html/Helpers/PreviewScrips line 115.

http://lists.bestpractical.com/pipermail/rt-users/2016-April/087217.html

I've been seeing this error since the release of 4.4.  It was mentioned 
here on the list, and at the time I thought a fix would surely make its 
way down the pipeline.  Sadly, I haven't seen one, so I found the error 
and fixed it the other day.  If this is causing your users to miss 
replies to tickets, the issue is fairly simple to fix.  The attached 
patch corrects the problem by quoting a variable that has overloaded 
operators, so that it's treated like a string.  I've also sent this 
patch to rt-devel.


--=_ascension.private.dragonsdawn.-19989-1487289637-0001-2
Content-Type: text/x-patch; name="rt4-previewscrips.patch"; charset=iso-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="rt4-previewscrips.patch"

--- rt-4.4.1/share/html/Helpers/PreviewScrips.orig	2017-02-15 19:52:17.761241782 +0000
+++ rt-4.4.1/share/html/Helpers/PreviewScrips	2017-02-15 19:52:36.460407904 +0000
@@ -112,7 +112,7 @@
 %                 $recips{$addr->address}++;
                   <b><%loc($type)%></b>:
 %                 my $show_checkbox = 1;
-%                 if ( grep {$_ eq $addr->address} @{$action->{NoSquelch}{$type}} ) {
+%                 if ( grep {$_ eq "$addr->address"} @{$action->{NoSquelch}{$type}} ) {
 %                     $show_checkbox = 0;
 %                 }
 

--=_ascension.private.dragonsdawn.-19989-1487289637-0001-2--