Re: Patch review expectations

On Thu, 27 Sep 2018, Ralf Schlatterbeck wrote:

> On Thu, Sep 27, 2018 at 10:50:23AM +0000, Joseph Myers wrote:
> > When should one commit one's own patches without review, versus waiting 
> > for them to be reviewed?
> > 
> > I've generally been committing Python-3-related patches without expecting 
> > review for them.  But I also have some other bug-fix patches attached to 
> > tracker issues without review (since 2014 in one case).  Should I just 
> > commit these (with appropriate CHANGES.txt updates) if no concerns have 
> > been raised about them?
> 
> Yes just commit these. I'm generally looking through the commits
> especially if I don't understand the changes from what SF sends me :-)

OK, I've now committed a couple of patches like that.  (I have a third 
unresolved patch from 2012 - issue2550750 - but in that case there were 
some concerns raised in the discussion, although I still think the patch 
is correct as-is, both as a matter of being consistent with the intent of 
the existing code quoted in the discussion in that issue and as a matter 
of the general principle that "a user's network connection had problems 
while they were accessing a website" is a matter for that user, not 
something for the site to generate an automatic email to the admin about.)

-- 
Joseph S. Myers
[email protected]