Re: POST JSON vs. urlencoded

Hi Ralf:

Just geting caught up on emails.

oIn message <[email protected]>,
Ralf Schlatterbeck writes:
>On Tue, Apr 02, 2019 at 06:19:37PM -0400, John P. Rouillard wrote:
>> Try this patch:
>> +            if type(val) == str:
>
>Patch except the quoted line above works fine except that with python2
>we need to check for unicode, too, not just "str".
>There is a function in anypy/strings.py that I've used for this.
>Otherwise I get an error when sending a title with german umlaut
>characters in in, e.g.,
>title = 'äöüÄÖÜß'

Got it. I was wondering how you got unicode at that point as the input
stream is bytes. Non ASCII 7 bit chars in the input must cause the
byte stream to become unicode. I never saw that, but I am only use
English (despite many attempts to lear with other human languages). I
wouldn't even know how to compose a character on my keyboard if I had
to.

>I currently have a customer testing this,

Very nice. Nothing like having a real use case to flush out the corner cases.

>so forgive me that I've committed and pushed the (modified) patch.

No need for forgiveness. Commiting it is fine if it works and you need
it. It's even more fine fine if I am asleep 8-).

Have a great day.
--
				-- rouilj
John Rouillard
===========================================================================
My employers don't acknowledge my existence much less my opinions.


_______________________________________________
Roundup-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/roundup-devel