Re: Put memorydb in roundup path?

Hi Ralf:

In message <[email protected]>,
Ralf Schlatterbeck writes:
>On Tue, Mar 30, 2021 at 12:13:04PM -0400, John P. Rouillard wrote:
>> Hi Ralf:
>> 
>> In message <[email protected]>,
>> Ralf Schlatterbeck writes:
>> >I've pushed my changes. Note that the test/test_config.py seems to have
>> >been broken before my changes.
>> 
>> Hmm, the only breakage I know of caused by a debugging print statement
>> that was accidently left in. But it broke tests of the admin interfce
>> not config.
>> 
>> What failure were you seeing in test_config?
>> 
>> I just did a bunch of updates to test_config due to changes in
>> configuration.py.  Everything is passing in CI for me at the
>> moment. Are you still seeing breakage?
>
>Yes I'm seeing three failing tests in test/test_config.py
>with both, python2 and python3. Am I missing something here?
>Should I create an issue for it?
>Maybe the tests have to be made conditional on installed xapian?

Yup. Two of them should. The third needs a guard checking to see if
xapian._xapian exists in sys.modules before trying to delete it (or
add a try, expect KeyError: pass section).

I'll also add a test that runs if xapian is not installed and verifies
that indexer_language = NO_LANG doesn't raise an error. (This test
already exists but mucks with sys.moduels to pretend xapian is
unavailable.)

Followups on the ticket.

--
				-- rouilj
John Rouillard
===========================================================================
My employers don't acknowledge my existence much less my opinions.