[issue2551352] classic classhelper overwrites current window if javascript is disabled.

New submission from John Rouillard:

The result of calling db.<class>.classhelp() results in an a tag with an
href of the backend end classhelper template. It depends on an onclick
handler to open a popup window. However if javascript is disabled, clicking
on the link replaces the current page because the a link is missing a target
attribute.

E.G.

   <a class="classhelp" [...] href="issue? 
@startwith=0&amp;@template=help&amp;properties=id,title&amp;property=superseder&amp;form=itemS
ynopsis&amp;type=checkbox&amp;@sort=title&amp;@pagesize=100" onclick="javascript:[...]">\

This could result in lost work if the browsers back button doesn't
restore filled in data. I am going to add a target="_blank" to the
generated a link to open the classhelper in a new window/tab.

Also if javascript is disabled, the classhelper doesn't and can't work
even in a new window. Without javascript there is no way to select items
and insert them into the original page. It is useful for paging through
the results and manually copying id numbers to the original page.

So I am also going to add a noscript tag to the top of the classhelper
to tell people that clicking on apply/cancel etc. don't work. It will
show up only when javacript is unavailable leaving the classhelper
usable for read only viewing of the data.

This should not change how the new classhelper web component acts. The target
parameter is used only if the a link gets a click event. Since the web component
prevents the link from getting a click event, the target is ignored.

----------
assignee: rouilj
components: Web interface
keywords: Blocker
messages: 8052
nosy: rouilj
priority: normal
severity: normal
status: new
title: classic classhelper overwrites current window if javascript is disabled.
type: behavior

_________________________________________________
Roundup tracker <[email protected]>
<https://issues.roundup-tracker.org/issue2551352>
_________________________________________________