[issue2551384] Modify flow in client.py's REST hander to verify authorization earlier??

New submission from John Rouillard:

Currently the rest flow is:

  check validity of origin header and log and return if missing/or value not
  acceptable

  check to see if it's a CORS preflight request if so process the request and
  return. All of these are done as the anonymous user since credentials are
  not sent. Currently cors processing only checks to see if the Origin header
  is present, not if it's valid.

  check if user is authorized to use REST, return 403 if not.

I want to change this to:

  check to see if it's a CORS preflight request if so process the request.
  The origin will be validated as part of the change.

  check if user is authorized to use REST returning 403 if not.

  check validity of origin header and log and return if missing/or value not
  acceptable

The old flow allows any user to generate bad origin header logging spam.
The new flow requires the user to have REST access rights to generate bad header
logs. If anonymous is allowed to use rest, logging spam can still be generated.

Since a CORS request is done automatically by the browser, it should always include
an Origin header. Only somebody pretending to be CORS preflight would be missing
the Origin, so I don't think we lose any debugging capability by not logging
a missing Origin header in preflight mode.

Thoughts or concerns?

----------
assignee: rouilj
components: API
messages: 8240
nosy: rouilj
severity: normal
status: new
title: Modify flow in client.py's REST hander to verify authorization earlier??
type: behavior

_________________________________________________
Roundup tracker <[email protected]>
<https://issues.roundup-tracker.org/issue2551384>
_________________________________________________