Re: error with minimal template

On Sat, Sep 08, 2018 at 10:03:02AM -0400, John P. Rouillard wrote:
> At the top of page.html I see:
> 
>    kw_edit python:request.user.hasPermission('Edit', 'keyword');
> 
> If 'keyword' doesn't exist, will calling hasPermission throw an error?
> (Arguably it should return no permission and not throw an exception,
> but the exception makes sure that typoing a field name doesn't cause a
> silent failure.)

If I remember correctly, this wasn't the case but maybe there is 
a check now that makes it fail. I think my recent patch to the
history computation was also triggered by a permission check to
an unknown entity (the given nodeid didn't have a corresponding item
in the DB). So some permission checks definitely require the checked
item and/or class to exist.

> Going forward for the release I think we should remove the keyword
> references in the template since the minimal template is not supposed
> to support keywords out of the box.
Yes.

Given the recent bug-fixes to 1.6 and the fact that we already have a
release brach we may want to do a maintenance release before the
next major relase...

Ralf
-- 
Dr. Ralf Schlatterbeck                  Tel:   +43/2243/26465-16
Open Source Consulting                  www:   http://www.runtux.com
Reichergasse 131, A-3411 Weidling       email: [email protected]