Re: roundup.cgi.actions.ExportCSVAction broken?

Hello Tom,
On Tue, Feb 05, 2019 at 06:41:18PM +0000, Tom Ekberg wrote:
> 
>   TypeError: byte string value expected, value of type str found
...
> I'd suggest changing the above write method to something
> like this:
> 
> 
>     def write(self, data):
>         f = self.request.get_wfile()
>         self.write = f
>         return f(data.encode('utf-8') if isinstance(data, str) else data)
> 
> Is it just me or have you seen this problem too?

Thanks for the report.
I guess you're the first person to test the python3 changes with WSGI.
So, yes, I think you've found a bug. Can you test your proposed
modification (looks good to me) and report back if this works for you?
If you can give the modification as a patch (diff -u of the changes
against the latest version) it's easier to apply.

Also fine would be an issue in our issue-tracker:
https://issues.roundup-tracker.org/

Thanks,
Ralf
-- 
Dr. Ralf Schlatterbeck                  Tel:   +43/2243/26465-16
Open Source Consulting                  www:   http://www.runtux.com
Reichergasse 131, A-3411 Weidling       email: [email protected]