Re: Open Issues

Hi Tom:

In message <DM6PR08MB47782335E03F35EFEC63D19BCA430@DM6PR08MB4778.namprd08.prod.
outlook.com>,
Tom Ekberg writes:
>I have open 2 issues that I've been looking for in the mercurial
>patches. They are:
>
>2551018 - Allow changes to the email body of nosy emails.
>2551026 - template variable not defined even though it is
>
>While 2551018 is a feature request to allow one to define a function
>to generate the email body of nosy emails, 2551026 is a bug that
>causes the standard templates to fail to resolve variables in
>expressions. Anyone who uses template variables in the standard
>template language TAL with python3 may encounter this problem.
>
>I have attached patches to both issues. I was wondering how one gets
>issues like these into the patch pipeline.

I replied on the tickets. I asked Joseph to look at 2551026. That's a
python 3 issue and it looks like your patch solves it. However I have
no idea what your patch does. It looks well down in the weeds of
python internals.

Adding a test to the suite that:

  * passed with and without the ptch when running python 2
  * failed without the patch when running python 3
  * passed with the patch when running python 3

would make me feel better about applying it and trying to ensure that
it won't fail in the future.

Adding a test for your patch on 2551026 would also be good to have.

I try very hard not to add patches without tests.  There are stil some
patches that I was unable to generate tests for that never made it
into 1.6.0.

--
				-- rouilj
John Rouillard
===========================================================================
My employers don't acknowledge my existence much less my opinions.