Re: Anybody available to test patches for jinja2 template?
Christof Meerwald <[email protected]>
| Newsgroups | gmane.comp.bug-tracking.roundup.user |
|---|---|
| Message-ID | <[email protected]> |
On Mon, 20 May 2019 19:19:57 -0400, John P. Rouillard wrote:
> I would like to get these patches in place as they upgrade to
> bootstrap4 and do some other additions.
I guess the main question for the other additions is if adding a
"html_kwargs={}" parameter to the "submit" methods is the right thing
to do - or if it would be better adding that as "**kwargs" parameter.
"classhelp" and "menu" currently have "html_kwargs" parameters, but
"renderWith", "field", "multiline" have "**kwargs" parameters. I think
my preference would be to have "**kwargs" parameter as "submit" seems
pretty similar to "multiline" as it maps fairly directly to an HTML
"input" tag (similar to "multiline").
BTW, I have cleaned up whitespace changes and indentation for the
template changes at
https://bitbucket.org/cmeerw/roundup/commits/8b0f049af488becd1f18ff70dab23b9f23dd2557?at=jinja2-bootstrap
Christof
--
http://cmeerw.org sip:cmeerw at cmeerw.org
mailto:cmeerw at cmeerw.org xmpp:cmeerw at cmeerw.org