Re: Re: [Bx-bugs] [Bug 899] doctypes

one more thing:

On 27.1.2006 12:40 Uhr, qMax wrote:
> Friday, January 27, 2006, 5:02:59 PM, Christian Stocker wrote:
> 
> CS> Hi
> 
> CS> Thanks for that patch, but I have some questions.
> I've just sent a description of it and how to use it in this list.
> 
> CS> First: can't you put bx_xmldocconfig into bx_plugins_xmldoc_config?
> CS> Looks like that class will only be needed by the xmldoc plugin, so
> CS> bx/plugins/xmldoc/config.php is the more appropriate place than bx/,
> CS> where only general stuff should go.
> It's not a plugin, but a helper class to handle configfile.
> It is used both by plugin_xmldoc and resource_xmldoc.

Ok :) Can you put it then in bx/config/xmldoc.php? Maybe that's a more
appropriate place.

btw,  if it would have been only for the plugin, bx/plugins/xmldoc/
would have been the correct place as it belongs to
bx/plugins/xmldoc.php, even if it's not a plugin by itself. But I
understand your reasoning, so bx/config/ would be the correct place IMHO.

I just don't want to have too many php files directly in the bx/
directory (especially those, which do not belong to the more general
framework), that's the main argument from my side.

chregu

> 
> CS> Second: I'm a bit reluctant to add the
> "stylesheet" =>> $collection->getStylesheetNameByRequest($filename,$ext),
> 
> CS> by default to the bxcms action. It's another lookup added, which most
> CS> plugins don't need. OTOH, it doesn't look very expensive for most
> CS> plugins, so why not just adding it. There's just the other problem, that
> CS> it basically has the same meaning as the xslt parameter from .configxml.
> CS> Or do you use it for something else? Shouldn't it just be either xslt or
> CS> stylesheet?
> In .configxml there is a theme-related stylesheet.
> The pipeline parameter stylesheet is to transform xml document source
> into xhtml - it is different for each doctype,
> and there possible to have several doctypes in one collection.
> The stylesheet is configured in xmldocconfig, and could be retrieved
> by plugin_xmldoc, but it is not requested for pipeline properties.
> 
> CS> But looks good, do you have some examples somewhere to actually check it
> CS> out?
> Very soon i'll clean up my stylesheets for simplified docbook and
> glossary (a part of docbook also).
> 

-- 
christian stocker | Bitflux GmbH | schoeneggstrasse 5 | ch-8004 zurich
phone +41 44 240 56 70 | mobile +41 76 561 88 60 | fax +41 1 240 56 71
http://www.bitflux.ch | [email protected] |  GPG 0x5CE1DECB
-- 
bitflux-cms mailing list
[email protected]
http://lists.bitflux.ch/cgi-bin/listinfo/bitflux-cms