[gnue] r9796 - trunk/gnue-common/src/base

Author: johannes
Date: 2007-11-12 08:34:58 -0600 (Mon, 12 Nov 2007)
New Revision: 9796

Modified:
   trunk/gnue-common/src/base/log.py
Log:
Use a separate logger per exception following this pattern:
"exception.<group>.<classname>"

issue123 in-progress


Modified: trunk/gnue-common/src/base/log.py
===================================================================
--- trunk/gnue-common/src/base/log.py	2007-11-12 14:32:37 UTC (rev 9795)
+++ trunk/gnue-common/src/base/log.py	2007-11-12 14:34:58 UTC (rev 9796)
@@ -36,6 +36,7 @@
 import traceback
 
 from gnue.common.base import utils
+from gnue.common.apps import errors
 
 __all__ = ['logged_f', 'deprecated_f',
         'logged_f_n', 'deprecated_f_n',
@@ -309,14 +310,10 @@
     @param etraceback: Exception traceback
     @type etraceback: traceback
     """
-    # TODO: log to exception.system, exception.admin, or exception.application,
-    # depending on the exception group of gException.
-    # TODO: use getException to receive exception details instead of formatting
-    # the exception here. Could be implemented by overwriting
-    # Formatter.formatException().
-    # TODO: use a separate logger per exception class, like
-    # exception.admin.gnue.common.datasources.GDataSource.ResourceNotFoundError?
-    error_n('exception', "Unhandled exception occured",
+    (group, name, message, detail) = errors.getException(None, etype, evalue,
+            etraceback)
+    logger = "exception.%s.%s" % (group, etype)
+    error_n(logger, "Unhandled exception occured",
             exc_info=(etype, evalue, etraceback))
 
 # -----------------------------------------------------------------------------