svn commit: r565260 - /lenya/trunk/src/modules-core/workflow/java/src/org/apache/lenya/workflow/impl/WorkflowBuilder.java

[email protected]
Newsgroups gmane.comp.cms.lenya.cvs
Message-ID <[email protected]>
Author: nettings
Date: Mon Aug 13 00:55:41 2007
New Revision: 565260

URL: http://svn.apache.org/viewvc?view=rev&rev=565260
Log:
whitenoise, rearranged class properties.
FIXME: what is the "synchronized" attribute in workflow transitions?
looks like dead code, because it's not in the default pub, and the
validation schema does not even mention it...

Modified:
    lenya/trunk/src/modules-core/workflow/java/src/org/apache/lenya/workflow/impl/WorkflowBuilder.java

Modified: lenya/trunk/src/modules-core/workflow/java/src/org/apache/lenya/workflow/impl/WorkflowBuilder.java
URL: http://svn.apache.org/viewvc/lenya/trunk/src/modules-core/workflow/java/src/org/apache/lenya/workflow/impl/WorkflowBuilder.java?view=diff&rev=565260&r1=565259&r2=565260
==============================================================================
--- lenya/trunk/src/modules-core/workflow/java/src/org/apache/lenya/workflow/impl/WorkflowBuilder.java (original)
+++ lenya/trunk/src/modules-core/workflow/java/src/org/apache/lenya/workflow/impl/WorkflowBuilder.java Mon Aug 13 00:55:41 2007
@@ -38,6 +38,25 @@
  */
 public class WorkflowBuilder extends AbstractLogEnabled {
 
+    protected static final String STATE_ELEMENT = "state";
+    protected static final String TRANSITION_ELEMENT = "transition";
+    protected static final String EVENT_ELEMENT = "event";
+    protected static final String CONDITION_ELEMENT = "condition";
+    //protected static final String ACTION_ELEMENT = "action";
+    protected static final String ID_ATTRIBUTE = "id";
+    protected static final String INITIAL_ATTRIBUTE = "initial";
+    protected static final String SOURCE_ATTRIBUTE = "source";
+    protected static final String DESTINATION_ATTRIBUTE = "destination";
+    protected static final String CLASS_ATTRIBUTE = "class";
+    protected static final String VARIABLE_ELEMENT = "variable";
+    protected static final String ASSIGNMENT_ELEMENT = "assign";
+    protected static final String VARIABLE_ATTRIBUTE = "variable";
+    protected static final String VALUE_ATTRIBUTE = "value";
+    protected static final String NAME_ATTRIBUTE = "name";
+    protected static final String SYNCHRONIZED_ATTRIBUTE = "synchronized";
+
+    private ConditionFactory conditionFactory = null;
+
     /**
      * Ctor.
      * @param logger The logger to use.
@@ -135,23 +154,6 @@
                 && (initialAttribute.equals("yes") || initialAttribute.equals("true"));
     }
 
-    protected static final String STATE_ELEMENT = "state";
-    protected static final String TRANSITION_ELEMENT = "transition";
-    protected static final String EVENT_ELEMENT = "event";
-    protected static final String CONDITION_ELEMENT = "condition";
-    protected static final String ACTION_ELEMENT = "action";
-    protected static final String ID_ATTRIBUTE = "id";
-    protected static final String INITIAL_ATTRIBUTE = "initial";
-    protected static final String SOURCE_ATTRIBUTE = "source";
-    protected static final String DESTINATION_ATTRIBUTE = "destination";
-    protected static final String CLASS_ATTRIBUTE = "class";
-    protected static final String VARIABLE_ELEMENT = "variable";
-    protected static final String ASSIGNMENT_ELEMENT = "assign";
-    protected static final String VARIABLE_ATTRIBUTE = "variable";
-    protected static final String VALUE_ATTRIBUTE = "value";
-    protected static final String NAME_ATTRIBUTE = "name";
-    protected static final String SYNCHRONIZED_ATTRIBUTE = "synchronized";
-
     /**
      * Builds a state from an XML element.
      * @param element An XML element.
@@ -219,6 +221,8 @@
          */
 
         // set synchronization
+
+        /* FIXME: this is not used in the default publication, and is not currently accepted by the workflow xml validation. what does it do? */
         if (element.hasAttribute(SYNCHRONIZED_ATTRIBUTE)) {
             Boolean isSynchronized = Boolean.valueOf(element.getAttribute(SYNCHRONIZED_ATTRIBUTE));
             transition.setSynchronized(isSynchronized.booleanValue());
@@ -236,7 +240,6 @@
         return element.getAttribute(ID_ATTRIBUTE);
     }
 
-    private ConditionFactory conditionFactory = null;
 
     /**
      * Builds a condition from an XML element.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.