svn commit: r579952 - in /lenya/branches/branch_1_2_x_shibboleth/src/java/org/apache/shibboleth: impl/AssertionConsumerServiceImpl.java media/RedirectMediaResource.java saml/HttpHookImpl.java

Author: andreas
Date: Thu Sep 27 02:05:52 2007
New Revision: 579952

URL: http://svn.apache.org/viewvc?rev=579952&view=rev
Log:
[minor change] Javadoc cleanup

Modified:
    lenya/branches/branch_1_2_x_shibboleth/src/java/org/apache/shibboleth/impl/AssertionConsumerServiceImpl.java
    lenya/branches/branch_1_2_x_shibboleth/src/java/org/apache/shibboleth/media/RedirectMediaResource.java
    lenya/branches/branch_1_2_x_shibboleth/src/java/org/apache/shibboleth/saml/HttpHookImpl.java

Modified: lenya/branches/branch_1_2_x_shibboleth/src/java/org/apache/shibboleth/impl/AssertionConsumerServiceImpl.java
URL: http://svn.apache.org/viewvc/lenya/branches/branch_1_2_x_shibboleth/src/java/org/apache/shibboleth/impl/AssertionConsumerServiceImpl.java?rev=579952&r1=579951&r2=579952&view=diff
==============================================================================
--- lenya/branches/branch_1_2_x_shibboleth/src/java/org/apache/shibboleth/impl/AssertionConsumerServiceImpl.java (original)
+++ lenya/branches/branch_1_2_x_shibboleth/src/java/org/apache/shibboleth/impl/AssertionConsumerServiceImpl.java Thu Sep 27 02:05:52 2007
@@ -254,7 +254,6 @@
      * Uses an HTTP Status 307 redirect to forward the user the HS.
      * @param ureq
      * @param getRequestString parameter string for request to IdP
-     * @throws OLATRuntimeException
      */
     /*
      * public void forwardToHS(UserRequest ureq, String getRequestString) throws ShibbolethException {

Modified: lenya/branches/branch_1_2_x_shibboleth/src/java/org/apache/shibboleth/media/RedirectMediaResource.java
URL: http://svn.apache.org/viewvc/lenya/branches/branch_1_2_x_shibboleth/src/java/org/apache/shibboleth/media/RedirectMediaResource.java?rev=579952&r1=579951&r2=579952&view=diff
==============================================================================
--- lenya/branches/branch_1_2_x_shibboleth/src/java/org/apache/shibboleth/media/RedirectMediaResource.java (original)
+++ lenya/branches/branch_1_2_x_shibboleth/src/java/org/apache/shibboleth/media/RedirectMediaResource.java Thu Sep 27 02:05:52 2007
@@ -30,70 +30,53 @@
  */
 public class RedirectMediaResource extends AbstractLogEnabled implements MediaResource {
 
-    private String redirectURL;
+    private String redirectUrl;
 
     /**
-     * @param redirectURL
+     * @param redirectURL The redirect URL.
+     * @param logger The logger.
      */
     public RedirectMediaResource(String redirectURL, Logger logger) {
         ContainerUtil.enableLogging(this, logger);
-        this.redirectURL = redirectURL;
+        this.redirectUrl = redirectURL;
     }
 
-    /**
-     * @see org.olat.core.gui.media.MediaResource#getContentType()
-     */
     public String getContentType() {
         return null;
     }
 
-    /**
-     * @see org.olat.core.gui.media.MediaResource#getSize()
-     */
     public Long getSize() {
         return null;
     }
 
-    /**
-     * @see org.olat.core.gui.media.MediaResource#getInputStream()
-     */
     public InputStream getInputStream() {
         return null;
     }
 
-    /**
-     * @see org.olat.core.gui.media.MediaResource#getLastModified()
-     */
     public Long getLastModified() {
         return null;
     }
 
-    /**
-     * @see org.olat.core.gui.media.MediaResource#prepare(javax.servlet.http.HttpServletResponse)
-     */
     public void prepare(HttpServletResponse hres) {
         try {
-            hres.sendRedirect(redirectURL);
+            hres.sendRedirect(redirectUrl);
         } catch (IOException e) {
             // if redirect failed, we do nothing; the browser may have stopped
             // the
             // tcp/ip or whatever
-            getLogger().error("redirect failed: url=" + redirectURL, e);
+            getLogger().error("redirect failed: url=" + redirectUrl, e);
         } catch (IllegalStateException ise) {
             // redirect failed, to find out more about the strange null null
             // exception
             // FIXME:pb:a decide if this catch has to be removed again, after
             // finding problem.
-            getLogger().error("redirect failed: url=" + redirectURL, ise);
+            getLogger().error("redirect failed: url=" + redirectUrl, ise);
             // introduced only more debug information but behavior is still the
             // same
             throw (ise);
         }
     }
 
-    /**
-     * @see org.olat.core.gui.media.MediaResource#release()
-     */
     public void release() {
         // nothing to do
     }

Modified: lenya/branches/branch_1_2_x_shibboleth/src/java/org/apache/shibboleth/saml/HttpHookImpl.java
URL: http://svn.apache.org/viewvc/lenya/branches/branch_1_2_x_shibboleth/src/java/org/apache/shibboleth/saml/HttpHookImpl.java?rev=579952&r1=579951&r2=579952&view=diff
==============================================================================
--- lenya/branches/branch_1_2_x_shibboleth/src/java/org/apache/shibboleth/saml/HttpHookImpl.java (original)
+++ lenya/branches/branch_1_2_x_shibboleth/src/java/org/apache/shibboleth/saml/HttpHookImpl.java Thu Sep 27 02:05:52 2007
@@ -72,7 +72,7 @@
      */
     public boolean incoming(HttpServletRequest r, Object globalCtx, Object callCtx)
             throws SAMLException {
-        getLogger().error("OLATHttpHook method incoming-1 should not have been called.");
+        getLogger().error("Method incoming-1 should not have been called.");
         return true;
     }
 
@@ -82,7 +82,7 @@
      */
     public boolean outgoing(HttpServletResponse r, Object globalCtx, Object callCtx)
             throws SAMLException {
-        getLogger().error("OLATHttpHook method outgoing-1 should not have been called.");
+        getLogger().error("Method outgoing-1 should not have been called.");
         return true;
     }