svn commit: r603545 - /lenya/branches/branch_1_2_x_shibboleth/src/java/org/apache/lenya/ac/shibboleth/ShibbolethAuthenticator.java

[email protected]
Newsgroups gmane.comp.cms.lenya.cvs
Message-ID <[email protected]>
Author: andreas
Date: Wed Dec 12 02:38:34 2007
New Revision: 603545

URL: http://svn.apache.org/viewvc?rev=603545&view=rev
Log:
ShibbolethAuthenticator.getTargetUri(): log warning if TARGET request parameter is missing.

Modified:
    lenya/branches/branch_1_2_x_shibboleth/src/java/org/apache/lenya/ac/shibboleth/ShibbolethAuthenticator.java

Modified: lenya/branches/branch_1_2_x_shibboleth/src/java/org/apache/lenya/ac/shibboleth/ShibbolethAuthenticator.java
URL: http://svn.apache.org/viewvc/lenya/branches/branch_1_2_x_shibboleth/src/java/org/apache/lenya/ac/shibboleth/ShibbolethAuthenticator.java?rev=603545&r1=603544&r2=603545&view=diff
==============================================================================
--- lenya/branches/branch_1_2_x_shibboleth/src/java/org/apache/lenya/ac/shibboleth/ShibbolethAuthenticator.java (original)
+++ lenya/branches/branch_1_2_x_shibboleth/src/java/org/apache/lenya/ac/shibboleth/ShibbolethAuthenticator.java Wed Dec 12 02:38:34 2007
@@ -296,8 +296,14 @@
     }
 
     public String getTargetUri(Request request) {
-        String target = request.getParameter(AssertionConsumerServiceImpl.REQ_PARAM_TARGET);
-        return target != null ? target : request.getRequestURI();
+        String paramName = AssertionConsumerServiceImpl.REQ_PARAM_TARGET;
+        String target = request.getParameter(paramName);
+        if (target == null) {
+            getLogger().warn("Request parameter " + paramName + " is missing, using current URI as target.");
+            return request.getRequestURI();
+        } else {
+            return target;
+        }
     }
 
 }
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.