Re: Ready for a 2.0.4 release ?

@Rudolf :
Yes sure, we have to do a 2.1.x release but for now I think we have to
finish the 2.0 branch with a release that solve some bugs.
When this release done, we merge changes from 2.0.4 to 2.1.x and go for
a new release.
If you want to work on the 2.1.x release preparation you are very welcome !

Some comments inside :

On 12/12/2010 05:06 PM, Rainer Schöpf wrote:
> On Fri, 10 Dec 2010 at 14:22 +0100, florent andré wrote:
> 
>  > Hi there,
>  > 
>  > Hope you are fine.
>  > 
>  > What's your opinion about manage a release before end of year / at the
>  > begin of the new ?
> 
> +1
> 
> Let's freeze the code now.
> 
>  > You see some still alive key points to adress?
> 
> At least one junit test fails, and I don't understand why.  I failed to run the 
> junit tests under Eclipse, so I cannot debug the problem.

Yep,
$ ./build.sh test
give me this :


Compiling 1 source file to
/home/florent/devel/dev-lenya/lenyaSources/2.0.4-preparation/build/lenya/modules/org.apache.lenya.modules.export/java/test

{{Strange warning}}

WARNING: multiple versions of ant detected in path for junit

jar:file:/home/florent/devel/dev-lenya/lenyaSources/2.0.4-preparation/tools/lib/ant.jar!/org/apache/tools/ant/Project.class
     and
jar:file:/home/florent/devel/dev-lenya/lenyaSources/2.0.4-preparation/build/lenya/webapp/WEB-INF/lib/ant.jar!/org/apache/tools/ant/Project.class

{{error}}

Running org.apache.lenya.cms.export.ImportTest
Testsuite: org.apache.lenya.cms.export.ImportTest
Tests run: 1, Failures: 1, Errors: 0, Time elapsed: 1.913 sec
Tests run: 1, Failures: 1, Errors: 0, Time elapsed: 1.913 sec
Testcase: testImport took 1.607 sec
	FAILED
null
junit.framework.AssertionFailedError
	at org.apache.lenya.cms.export.ImportTest.checkLinks(ImportTest.java:76)
	at org.apache.lenya.cms.export.ImportTest.testImport(ImportTest.java:57)

BUILD FAILED
/home/florent/devel/dev-lenya/lenyaSources/2.0.4-preparation/src/targets/modules-build.xml:109:
The following error occurred while executing this line:
/home/florent/devel/dev-lenya/lenyaSources/2.0.4-preparation/build/lenya/temp/modules-build.xml:2543:
Test org.apache.lenya.cms.export.ImportTest failed


The error come from :
src/modules/export/java/test/org/apache/lenya/cms/export/ImportTest.java

in :
protected void checkLinks(Area area) throws PublicationException,
ServiceException {
        SiteStructure site = area.getSite();
        Document source =
site.getNode("/index").getLink("en").getDocument();

        LinkManager linkManager = null;
        try {
            linkManager = (LinkManager)
getManager().lookup(LinkManager.ROLE);
            Link[] links = linkManager.getLinksFrom(source);
            assertTrue(links.length > 0); ///---> that the assert that
cause bug

        }
        finally {
            if (linkManager != null) {
                getManager().release(linkManager);
            }
        }


========================
With comment the assert that cause bug, another one is fired after :

Running org.apache.lenya.inbox.InboxTest
Testsuite: org.apache.lenya.inbox.InboxTest
Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 43.36 sec
Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 43.36 sec
Testcase: testInbox took 43.183 sec
Running org.apache.lenya.notification.NotificationTest
Testsuite: org.apache.lenya.notification.NotificationTest
Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 10.334 sec
Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 10.334 sec
Testcase: testNotification took 10.161 sec
	Caused an ERROR
null
java.lang.NullPointerException
	at
org.apache.lenya.cms.site.tree2.SiteTreeRevisionVerifier.eventFired(SiteTreeRevisionVerifier.java:33)
	at
org.apache.lenya.cms.observation.ObservationManager.notify(ObservationManager.java:88)
	at
org.apache.lenya.cms.observation.ObservationManager.eventFired(ObservationManager.java:101)
	at
org.apache.avalon.excalibur.component.ComponentProxyGenerator$ComponentInvocationHandler.invoke(ComponentProxyGenerator.java:143)
	at $Proxy20.eventFired(Unknown Source)
	at org.apache.lenya.cms.repository.SessionImpl.commit(SessionImpl.java:155)
	at
org.apache.lenya.notification.NotificationTest.testNotification(NotificationTest.java:61)

BUILD FAILED

sorry, can't do more on this for today.

> 
>  > @Rainer : as you do many things for this 2.0.4 release, do you
>  > want/could manage it ?
> 
> With some help, maybe. I haven't yet tried to build the windows binary.

I can give an hand. Just ask.

With "windows binary" you refer to this ? :
http://lenya.apache.org/docu/rm.html#N1010F
I think that this is not still done from a moment. Just sources are
distributed (see :
http://lenya.apache.org/docu20/installation20/download20.html)

> 
>  Rainer
> 
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]