[magnolia-dev] [JIRA] (TASKMGMT-28) Avoid creating User throwaway objects in TaskManager API

Federico Grilli created an issue

Task Management / https://jira.magnolia-cms.com/browse/TASKMGMT-28 TASKMGMT-28

Avoid creating User throwaway objects in TaskManager API

Issue Type:
Improvement

Affects Versions:
1.2.2

Assignee:
Unassigned

Created:
01/Jun/17 2:33 PM

Priority:
Neutral

Reporter:
Federico Grilli

Upon logging into AdminCentral, when Pulse initialises, the following method gets called several times
getTasksAmountByUserAndStatus:192, DefaultTasksManager (info.magnolia.task)
which, in turn, triggers
getUser:264, MgnlUserManager (info.magnolia.cms.security).
This results in the same user instance being created like 10 times.
Probably not much of a overhead and in any case the instance is local to a method so it will be thrown away immediately, still there could be room for some improvement.

Could be probably fixed if the TaskMgmt API would pass around the User object instead of just the user id, but that's quite a change on its own. If we passed the User object to TaskManager - we would be able to re-use User from MgnlContext.

https://jira.magnolia-cms.com/browse/TASKMGMT-28#add-comment
Add Comment

This message was sent by Atlassian JIRA (v7.2.6#72008-sha1:26175bf)

----------

----------------------------------------------------------------

For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html

Alternatively, use our forums: http://forum.magnolia-cms.com/

To unsubscribe, E-mail to: <[email protected]>

----------------------------------------------------------------