Re: Bug 1852: support creation of xmpp: field types in OGo
Helge Hess <[email protected]> Sun, 25 Mar 2007 21:13:14 +0200
| Newsgroups | gmane.comp.cms.opengroupware.discuss.general |
|---|---|
| Message-ID | <[email protected]> |
On Mar 25, 2007, at 20:11, Sebastian Reitenbach wrote: > Maybe that catches not all cases in > a first place, but at least adds a lot of flexibility, up to the time > someone comes up with something more sophisticated solution ;). Well, I prefer to leave out patches which just hack the software instead of implementing the thing "the right way". Or at least with a defined upgrade path. (people who want to have hacks, are free to patch it on their own) Otherwise we end up in exactly the rather crappy solution we have today for email1 (we are basically unable to fix that because so much code relies on that). Now I consider the given patches an edge case, but as mentioned all documentation on the new "types" should be marked explicitly "hack, high chance this type will go away in future versions" or something like this. Simply because I don't want to support regular users which get the hack deployed (because its in the mainline), use it and then need to upgrade to their real implementation in a later version :-/ When providing patches please also think of the x000 existing deployments. We can't just change the software to improve the specific issues of a single person (or even just a few). Don't get me wrong, patches are very welcome - _even_ if they don't get applied or only in a specific branch! After all every user is free to apply them on their own, hurray to the power off free software ;-) To close the issue from my side, if you feel that its useful, please commit it. After all the user has to configure the extended attributes to enable the feature and do not get them automagically. Thanks, Helge -- Helge Hess http://www.helgehess.eu/ -- OpenGroupware.org Discussion [email protected] http://mail.opengroupware.org/mailman/listinfo/discuss