Re: Some more XML-RPC questions

Helge Hess wrote:
[..]
>> Person:
>>   - Well, there we're a little confused about the Person document;
> 
> 
> Martin can probably tell more about Person documents when he is back ...
> 
>> the Address information is stored in a Map, where the key is the
>> name of the Address ("location", "mailing", etc).
> 
> 
> Yes.
> 
>> But the Phone information seems a little too redundant:
>> there is a list that contains the Phone types, then there is a
>> Map where the Phone documents are stored with their phone type as
>> key AND those Phone documents have again a field that stores the
>> Phones type... hmm... is there a reason for that?
> 
> 
> Not sure. The "model idea" is that you have a "company" record which has 
> named "address" and "phone" records (1:N, 1:N).
> 
> You may want to post a bug if you think there is redundant information. 
> Note that the information may indeed be redundant in the Document ObjC 
> object for speed and that the XML-RPC representation is autogenerated.
> Anyway, Martin must tell ;-) And I'm not sure whether we want to break 
> the output for legacy reasons.
> 
The phone types list contains the configured types which are available 
[Default: LSTeleType.Person] (see Defaults.plist in Logic/LSAddress).
The phones list contains the phone entries, the person really has in the 
database. So I think what is redundant is that this is a dictionary 
(phoneType mapped to entry containing the phoneType again). This was for 
speed in the Document ObjC object as Helge said. An array would be enough.

>>  - about the keys of the Map storing the Addres documents: are those
>> keys defined in OGo? I mean mustthe names "location", etc. be used or
>> are they user defined?
> 
> 
> In theory they are user defined, but in practice the WebUI frontend only 
> displayed the default set (AFAIK, Martin?) The set of default address 
> always created is LSAddressType, see Defaults.plist.
> 
> You may want to submit a bug "add user defined addresses" to Bugzilla.

Most parts of the Contact WebUI already take those configured types. 
[Default: LSAddressType.Person] At a first look I could only see a few 
hard-coded mappings (like the cvs-import mapping suggestions). This has 
to be tested, so submitting a bug would be ok.

> 
>>  - similar question about the phone types: are they userdefined or
>> standard in OGo?
> 
> 
> Somewhat like above. But I think the viewers display all available 
> phones, its configurable using the LSTeleType default (see 
> Defaults.plist in LSAddress).
Yes, it's configurable. But some entries like '01_tel' or '02_tel' 
should remain in this list. They are often used in overview lists. The 
same with the extended attribute 'email1'.

regards,
Martin


-- 
Martin Hoerning   www.opengroupware.org

-- 
OpenGroupware.org XML-RPC
[email protected]
http://mail.opengroupware.org/mailman/listinfo/xmlrpc