Re: mailing list size matters?

Joe Stewart <[email protected]> Wed, 16 Apr 2003 09:34:14 -0500
Newsgroups gmane.comp.cms.phpslash.devel
Message-ID <[email protected]>
On Tue, Apr 15, 2003 at 08:31:13PM -0400, Luis M wrote:
> 
> MOVED TO -devel ...
> 
> <snip>
> 
> > > >There is a typo:
> > > >
> > > >45 error_reporting(E_ALL,~E_WARN);
> > > >
> > > >should be something like (untested):
> > > >
> > > >error_reporting(E_ALL & ~E_WARN);
> > >
> > > Well, mails seems to be sent only to the first person on the list 
> >anyway.
> > > Kind of strange, don't you think ? I'm no good with php, but I did run a
> > > test to see what's happening.
> > >
> > > If I run with the standard .71 MailingList.class, it stops after the 
> >first
> > > address, but if I change the          while ($this->db->next_record()) {
> > > ... } to only be:
> > >           while ($this->db->next_record()) {
> > >              $name      = $this->db->Record["name"];
> > >              $email     = $this->db->Record["email"];
> > >              $dayback   = $this->db->Record["dayback"];
> > >              $this->message .= "To: $email <$name>\n";
> > >           } // End: while ( $this->db->next_record() )
> > >
> >
> >Well I know why it's broke now.  What I'm not sure about is why it
> >ever worked.
> 
> It never really worked, it only sent the first email and screwed the array 
> as you proved below.
> 
> >
> >if ( ($dayback != $tmpDay) && ( !($ary['override']) ) ) {
> >    $ary['body'] = $this->build_body($ary,$dayback);
> >}
> >
> >The call to build_body uses the same db object.  This screws up the
> >array for the current while loop.
> >
> >I got it to work by creating a new db object in build_body and using
> >it instead of this->db.
> >
> >Luis - can you work on this?
> >
> 
> Yes, I need to fix this as I mention before. I'll work in the phpslash-dev 
> module.
> 

nathan - Can you look at this too?  I don't see how it ever would have
worked.

> I wanted to ask you, what will happen to the phpslash-ft module? Are you 
> planning to keep sync'ing all changes manually everytime something is proven 
> to work in the -dev module? or you will use the "stable" phpslash module 
> once phpslash-dev becomes stable enough to do a new release?
> In whichever case, I'll try to fix this and the poll bugs reported before in 
> the phpslash-dev module.
> 

I had hoped there would be more discussion whether the changes in the 
phpslash-dev tree were the right direction and to nail down how we 
wanted to proceed.  The back-end development list had some recent comments:

	http://sourceforge.net/mailarchive/message.php?msg_id=4302489

The sf.net archive isn't working too well at the moment.  You might 
have to go the the list archive to follow the thread. 	

I haven't been able to keep the -dev tree synced with the bugfixes in 
the -ft tree.

So for the moment, keep working in the -ft tree.

thanks,

Joe

> <snip>
> 
> ----)(-----
> Luis Mondesi
> System Administrator
> LatinoMixed.com
> 
> [email protected]
> 
> "...The Mac does this so smoothly, it feels like an extension of your mind." 
> - Paula Speer, MacWorld Magazine 2003-04
> 
> Public signature: http://www.latinomixed.com/lems1/public-a.asc
> 


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf