Re: login form/md5 js error

Hello,

On Mon, Apr 07, 2003 at 05:08:47AM +0000, Jimmy Chamberlin wrote:
> I upgraded to the new PSL .71 and everything went fine except a small 
> problem on the login page. (The plus is the cookie to stay logged in works!) 
> When I try and login IE says there is a javascript error when you hit 
> 'login'. The first time it just returned to the login page, but when I tried 
> again it seemed to work fine (but IE still gave the js error). [The 
> loginformCR has the setcookie line that was missing.]
> 

Well crud.  It's a new bug related to changing to a maintained md5.js.

What browser version/platform?  I was able to get the error on Mac 
0S9.0.4/IE5.1.4.

> Just wondering if anyone else had this come up or if its something on my 
> end. Hmm, when I uploaded the old version of md5.js that came with .7 I no 
> longe get that error.
> 

Nobody had reported it previously.

It looks like in loginformCR.tpl and loginblock.tpl, the MD5 function 
needs to be called hex_md5:

7,10c7,8
<     str = MD5(document.login.username.value + ":" +
<               document.login.password.value) + ":" +
<           document.login.challenge.value;
<     document.login.response.value = MD5(str);
---
>     str = hex_md5(document.login.username.value + ":" + 
document.login.password.value) + ":" + document.login.challenge.value;
>     document.login.response.value = hex_md5(str);
13c11
<     document.logintrue.response.value = MD5(str);
---
>     document.logintrue.response.value = hex_md5(str);

thanks,

Joe

> Well, thanks.
> 
> 
> 


-------------------------------------------------------
This SF.net email is sponsored by: ValueWeb: 
Dedicated Hosting for just $79/mo with 500 GB of bandwidth! 
No other company gives more support or power for your dedicated server
http://click.atdmt.com/AFF/go/sdnxxaff00300020aff/direct/01/