[TikiWiki-commits] [Git][tikiwiki/tiki][29.x] [BP][FIX] wikiplugin_pdf: Ensure single quotes in parameters are encoded as HTML

Sammy Ndabo pushed to branch 29.x at Tiki Wiki CMS Groupware / Tiki


Commits:
5ecfcaf1 by Sammy Ndabo at 2025-08-13T12:07:34+00:00
[BP][FIX] wikiplugin_pdf: Ensure single quotes in parameters are encoded as HTML
---
* [FIX] wikiplugin_pdf: Ensure single quotes in parameters are encoded as HTML
---
* [FIX] wikiplugin_pdf: Ensure single quotes in parameters are encoded as HTML

* [FIX] wikiplugin_tracker: Allow not having a preview button

See merge request tikiwiki/tiki!8282

(cherry picked from commit c89b79353479afdef8184f80847b77ea77b83fac)

* [NEW] ExportPDF: Add new action for ListExecute to export a wiki page as PDF and a console command
---
* [REF] PagePdfExporter: refactor PDF generation logic

* [ENH] PagePrintCommand: add warning message for default PDF export path as there are saved in a publicly accessible place

* [ENH] PagePrintCommand: update output option description for clarity on PDF export path

* [FIX] PagePrintCommand: update command description to accurately reflect PDF export functionality

* [REF] PagePdfExporter: streamline page access validation and enhance error handling

* [FIX] PagePdfExporter: fix lints and namespace error

* [FIX] PagePdfExporter: Use output path for exported PDFs default to TEMP_PUBLIC_PATH and ensure any defined directory exists

* [FIX] PagePdfExporter: Improve error handling for PDF generation failure

* [FIX] wikiplugin_listexecute.php: Fix export PDF action class name in listexecute plugin

* [REF] wiki to PDF export functionality: delegate to PagePdfExporter and streamline PagePrintCommand

* [NEW] Add PagePrintCommand to export a printer-friendly version of a page

* Fix a few phpcs lints errors

* [NEW] ExportPDF: Add new action for ListExecute to export a wiki page as PDF

See merge request tikiwiki/tiki!7767

(cherry picked from commit 7ed31d9cee2754f4d7e078098923f9d950b62019)

See merge request tikiwiki/tiki!8283

- - - - -


1 changed file:

- lib/wiki-plugins/wikiplugin_pdf.php


Changes:

=====================================
lib/wiki-plugins/wikiplugin_pdf.php
=====================================
@@ -309,6 +309,10 @@ function wikiplugin_pdf($data, $params)
     $paramList = '';
     //creating string of data paramaters set by user
     foreach ($params as $paramName => $param) {
+        if (str_contains($param, '\'')) {
+            // encode single quotes as html
+            $param = str_replace('\'', ''', $param);
+        }
         $paramList .= $paramName . "='" . $param . "' ";
     }
     return "<pdfsettings " . $paramList . "></pdfsettings>";



View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/5ecfcaf1495dd54d7719b35607c4f2917b4ed0e2

-- 
View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/5ecfcaf1495dd54d7719b35607c4f2917b4ed0e2
You're receiving this email because of your account on gitlab.com.

_______________________________________________
TikiWiki-cvs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs