[TikiWiki-commits] [Git][tikiwiki/tiki][master] [FIX] ODBC: fix sql server max value get query

"Victor Emanouilov \(@kroky\) via TikiWiki-cvs" <[email protected]>
Newsgroups gmane.comp.cms.tiki.cvs
Message-ID <68a2f08b45e95_2cd6dbc8552e@gitlab-sidekiq-low-urgency-cpu-bound-v2-5d7cc58987-lwkql.mail>

Victor Emanouilov pushed to branch master at Tiki Wiki CMS Groupware / Tiki


Commits:
48492a5d by Victor Emanouilov at 2025-08-18T12:21:06+03:00
[FIX] ODBC: fix sql server max value get query

- - - - -


1 changed file:

- lib/core/Tracker/Tabular/ODBCManager.php


Changes:

=====================================
lib/core/Tracker/Tabular/ODBCManager.php
=====================================
@@ -301,7 +301,11 @@ class ODBCManager
     {
         $this->handleErrors();
         $conn = $this->getConnection();
-        $sql = "SELECT MAX(CAST(\"$field\" AS DECIMAL(20,0))) as last from {$this->config['table']} WHERE \"$field\" REGEXP '^[0-9]+$'";
+        if (stristr($this->config['dsn'], 'mysql') || stristr($this->config['dsn'], 'mariadb')) {
+            $sql = "SELECT MAX(CAST(\"$field\" AS SIGNED)) as last from {$this->config['table']} WHERE \"$field\" REGEXP '^[0-9]+$'";
+        } else {
+            $sql = "SELECT MAX(CAST(\"$field\" AS INT)) as last from {$this->config['table']} WHERE ISNUMERIC(\"$field\") = 1";
+        }
         $rs = odbc_prepare($conn, $sql);
         if ($rs) {
             odbc_execute($rs, []);



View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/48492a5d1dbb7dc1cd7b79fed3d1fc447bc8b213

-- 
View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/48492a5d1dbb7dc1cd7b79fed3d1fc447bc8b213
You're receiving this email because of your account on gitlab.com.

_______________________________________________
TikiWiki-cvs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.