[TikiWiki-commits] [Git][tikiwiki/tiki][master] [FIX] Review Tiki DSN empty entries

ushindi bienvenu pushed to branch master at Tiki Wiki CMS Groupware / Tiki


Commits:
6aba860c by Landry Bitege at 2025-08-20T17:33:01+00:00
[FIX] Review Tiki DSN empty entries
---
* [FIX] Review Tiki DSN empty entries

See merge request tikiwiki/tiki!8041

- - - - -


1 changed file:

- tiki-admin_dsn.php


Changes:

=====================================
tiki-admin_dsn.php
=====================================
@@ -49,11 +49,15 @@ if (isset($_REQUEST["remove"]) && $access->checkCsrf(true)) {
     }
 }
 if (isset($_REQUEST["save"]) && $access->checkCsrf()) {
-    $result = $adminlib->replace_dsn($_REQUEST["dsnId"], $_REQUEST["dsn"], $_REQUEST['name']);
-    if ($result && $result->numRows()) {
-        Feedback::success(tr('DSN created or modified'));
+    if (empty(trim($_REQUEST["name"])) || empty(trim($_REQUEST["dsn"]))) {
+        Feedback::error(tr('Both DSN and name fields are required.'));
     } else {
-        Feedback::error(tr('DSN not created or modified'));
+        $result = $adminlib->replace_dsn($_REQUEST["dsnId"], $_REQUEST["dsn"], $_REQUEST['name']);
+        if ($result && $result->numRows()) {
+            Feedback::success(tr('DSN created or modified'));
+        } else {
+            Feedback::error(tr('DSN not created or modified'));
+        }
     }
     $info = [];
     $info["dsn"] = '';



View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/6aba860c0e2b94374a36854c4c91a3816d73a00c

-- 
View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/6aba860c0e2b94374a36854c4c91a3816d73a00c
You're receiving this email because of your account on gitlab.com.

_______________________________________________
TikiWiki-cvs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs