[TikiWiki-commits] [Git][tikiwiki/tiki][29.x] [FIX] Failed sending mail with no recipients

ushindi bienvenu pushed to branch 29.x at Tiki Wiki CMS Groupware / Tiki


Commits:
76eebfdc by ushindi bienvenu at 2025-08-21T02:12:17+00:00
[FIX] Failed sending mail with no recipients
---
* [FIX] Failed sending mail with no recipients
---
* [FIX] Failed sending mail with no recipients

See merge request tikiwiki/tiki!8316

See merge request tikiwiki/tiki!8354

- - - - -


1 changed file:

- lib/core/Tiki/Command/MailQueueSendCommand.php


Changes:

=====================================
lib/core/Tiki/Command/MailQueueSendCommand.php
=====================================
@@ -38,15 +38,15 @@ class MailQueueSendCommand extends Command
             $output->writeln('Sending message ' . $messageId . '...');
             $mail = unserialize($serializedEmail);
             $error = '';
-
             if ($mail instanceof Email) {
                 $tikiMail = new \TikiMail();
                 $tikiMail->setFrom($mail->getFrom()[0]->getAddress(), $mail->getFrom()[0]->getName());
                 $tikiMail->setSubject($mail->getSubject());
                 $recipients = $this->collectRecipients($mail);
-
-                if ($tikiMail->send($recipients)) {
-                    $query = 'DELETE FROM tiki_mail_queue WHERE messageId = ?';
+                $query = 'DELETE FROM tiki_mail_queue WHERE messageId = ?';
+                if (empty($recipients)) {
+                    $output->writeln('Deleted object id: ' . $messageId . ' (mail has no recipients)');
+                } elseif ($tikiMail->send($recipients)) {
                     $output->writeln('Sent.');
                 } else {
                     $query = 'UPDATE tiki_mail_queue SET attempts = attempts + 1 WHERE messageId = ?';



View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/76eebfdc850e8f7e56ff1e3cb8d10f678a018fb0

-- 
View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/76eebfdc850e8f7e56ff1e3cb8d10f678a018fb0
You're receiving this email because of your account on gitlab.com.

_______________________________________________
TikiWiki-cvs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs