[TikiWiki-commits] [Git][tikiwiki/tiki][24.x] [FIX] Include deprecated feedback type in console verbosity check

SoftStart Code pushed to branch 24.x at Tiki Wiki CMS Groupware / Tiki


Commits:
de0a9f00 by Sandeep D at 2025-10-13T23:20:55+00:00
[FIX] Include deprecated feedback type in console verbosity check
---
* [FIX] Include deprecated feedback type in console verbosity check
---
* [FIX] Include deprecated feedback type in console verbosity check

Fixes issue where feedback type messages were always printed to console regardless of verbosity level, causing unwanted output in profile application

Problem:
- Feedback::success() sets type to feedback (deprecated but kept for backward compatibility)
- Feedback::printToConsole() only checks for success or note types when determining if verbosity is required
- Result: feedback messages bypass verbosity check and always print
- Affects profile testing: Shows false warnings like in Spreadsheet demo

Solution:
- Added feedback to verbosity check in printToConsole()

See merge request tikiwiki/tiki!8756


(cherry picked from commit 315db4d448ba44f0767d82016f79c5757d3ed1e3)

Co-authored-by: Sandeep D <sandeep.anandbhai-NHSG37FGo5wS/6/[email protected]>

See merge request tikiwiki/tiki!8770

- - - - -


1 changed file:

- lib/core/Feedback.php


Changes:

=====================================
lib/core/Feedback.php
=====================================
@@ -281,7 +281,7 @@ class Feedback
                         $message = $type . ': ' . str_replace('<br />', "\n", $message['mes']);
                     }
 
-                    if ($type === 'success' || $type === 'note') {
+                    if ($type === 'success' || $type === 'note' || $type === 'feedback') {
                         if (! $output->isVeryVerbose()) {
                             continue;
                         }



View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/de0a9f0062d1e92bccd32ebc7b57056a236d8a0b

-- 
View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/de0a9f0062d1e92bccd32ebc7b57056a236d8a0b
You're receiving this email because of your account on gitlab.com.

_______________________________________________
TikiWiki-cvs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs