[TikiWiki-commits] [Git][tikiwiki/tiki][master] [FIX][REF] SCSS: Remove obsolete 'mixed-decls' deprecation flag from build configuration

Benoit Grégoire (@benoitg) via TikiWiki-cvs <[email protected]>
Newsgroups gmane.comp.cms.tiki.cvs
Message-ID <68f6b598c6792_2ce0f4c6318d@gitlab-sidekiq-low-urgency-cpu-bound-v2-785d4f4d67-pzd8t.mail>

Benoit Grégoire pushed to branch master at Tiki Wiki CMS Groupware / Tiki


Commits:
581a6b32 by MAGENE Sem Joel at 2025-10-20T22:12:25+00:00
[FIX][REF] SCSS: Remove obsolete 'mixed-decls' deprecation flag from build configuration
---
* [FIX][REF] SCSS: Remove obsolete 'mixed-decls' deprecation flag from build configuration

See merge request tikiwiki/tiki!8824

- - - - -


2 changed files:

- src/js/vite.config.mjs
- src/scss/package.json


Changes:

=====================================
src/js/vite.config.mjs
=====================================
@@ -221,33 +221,6 @@ export default defineConfig(({ command, mode }) => {
             postcss: {
                 plugins: [postcssRootToHost()],
             },
-            /**
-             * This workaround suppresses warnings from Sass about mixed declarations
-             * after nested rules. The issue originates from Bootstrap (twbs) and is
-             * tracked here: https://github.com/twbs/bootstrap/issues/40621.
-             *
-             * The fix involves configuring the `scss` preprocessor to silence the specific
-             * deprecation warnings (`mixed-decls`). This is implemented using the `silenceDeprecations`
-             * option with the value `['mixed-decls']`.
-             *
-             * IMPORTANT: This workaround can be removed once Bootstrap is updated to
-             * version 5.3.4 (or later), which includes the resolution to this issue
-             * (see: https://github.com/twbs/bootstrap/pull/40623).
-             *
-             * Original suppressed warning:
-             * DEPRECATION WARNING: Sass's behavior for declarations that appear after nested rules
-             * will change in future versions.
-             *
-             * Future developers should verify whether the workaround is still required
-             * by consulting the linked issue and confirming that the fix is included in the
-             * version of Bootstrap used by the project.
-             */
-            preprocessorOptions: {
-                scss: {
-                    api: "modern-compiler", // or "modern", "legacy"
-                    silenceDeprecations: ["mixed-decls"],
-                },
-            },
         },
         plugins: [
             vue({


=====================================
src/scss/package.json
=====================================
@@ -4,14 +4,14 @@
   "description": "Sass (scss) build system for themes.  Note that for themes in _custom to actually work, you also need the main vite js build to run to copy the assets (images, fonts, etc.)",
   "type": "module",
   "scriptsComments": {
-    "build/watch": "The flags --silence-deprecation=color-functions,global-builtin,mixed-decls,import are there because as of 2025-06-09, bootstrap 5.3.6 hasn't fixed everything.  See https://github.com/orgs/twbs/discussions/41370.  In addition, our own code requires ignoring @import deprecation, because we can't run px sass-migrator module --migrate-deps --load-path=../../templates --load-path=../../themes ../../themes/**/**/*.scss on our own codebase until bootstrap is fixed.  benoitg - 2025-06-09"
+    "build/watch": "The flags --silence-deprecation=color-functions,global-builtin,import are there because as of 2025-06-09, bootstrap 5.3.6 hasn't fixed everything.  See https://github.com/orgs/twbs/discussions/41370.  In addition, our own code requires ignoring @import deprecation, because we can't run px sass-migrator module --migrate-deps --load-path=../../templates --load-path=../../themes ../../themes/**/**/*.scss on our own codebase until bootstrap is fixed.  benoitg - 2025-06-09 EDIT Jomagene 2025-10-20: The 'mixed-decls' flag was removed as it became obsolete in newer Sass compiler versions (post v1.92.0) and was causing a new build warning."
   },
   "scripts": {
     "test": "echo \"Error: no test specified\" && exit 1",
     "prebuild": "node scripts/check_custom.js",
     "prewatch": "node scripts/check_custom.js",
-    "build": "sass --load-path=../../templates --load-path=../../themes ../../themes ../../_custom:../../public/generated/_custom --silence-deprecation=color-functions,global-builtin,mixed-decls,import",
-    "watch": "sass --watch --load-path=../../templates --load-path=../../themes ../../themes ../../_custom:../../public/generated/_custom --silence-deprecation=color-functions,global-builtin,mixed-decls,import",
+    "build": "sass --load-path=../../templates --load-path=../../themes ../../themes ../../_custom:../../public/generated/_custom --silence-deprecation=color-functions,global-builtin,import",
+    "watch": "sass --watch --load-path=../../templates --load-path=../../themes ../../themes ../../_custom:../../public/generated/_custom --silence-deprecation=color-functions,global-builtin,import",
     "clean": "git clean -f -x \"../../themes/**/*.css\" \"../../themes/**/*.css.map\" \"../../public/generated/_custom/**/*.css\" \"../../public/generated/_custom/**/*.css.map\""
   },
   "author": "",



View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/581a6b320c73e570eefe9ec2607d3ff3f0cf27c5

-- 
View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/581a6b320c73e570eefe9ec2607d3ff3f0cf27c5
You're receiving this email because of your account on gitlab.com.

_______________________________________________
TikiWiki-cvs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.