[TikiWiki-commits] [Git][tikiwiki/tiki][master] [FIX] Webmail: avoid returning an error when no sent message was found, which...

"Victor Emanouilov \(@kroky\) via TikiWiki-cvs" <[email protected]>
Newsgroups gmane.comp.cms.tiki.cvs
Message-ID <68fb434475329_2c31fa31c2837a@gitlab-sidekiq-low-urgency-cpu-bound-v2-6797445444-7qxkp.mail>

Victor Emanouilov pushed to branch master at Tiki Wiki CMS Groupware / Tiki


Commits:
197512ae by Merci Jacob at 2025-10-24T09:05:54+00:00
[FIX] Webmail: avoid returning an error when no sent message was found, which triggers unwanted alerts to users – while auto-suggesting to move a message to a tracker item
---
* [FIX] Webmail: avoid returning an error when no sent message was found, which triggers unwanted alerts to users – while auto suggesting to move a message to a tracker item

See merge request tikiwiki/tiki!8845

- - - - -


3 changed files:

- lib/cypht/modules/tiki/general_modules.php
- lib/cypht/modules/tiki/js_modules/getSentMsgTrackerItems.js
- lib/cypht/modules/tiki/setup.php


Changes:

=====================================
lib/cypht/modules/tiki/general_modules.php
=====================================
@@ -510,7 +510,7 @@ class Hm_Handler_get_msg_tracker_items extends Hm_Handler_Module
         }
 
         if (! $keywords || ! $msgUid || ! $imapServerId) {
-            $this->out('error', 'No sent message found');
+            $this->out('no_message', true);
             return;
         }
 


=====================================
lib/cypht/modules/tiki/js_modules/getSentMsgTrackerItems.js
=====================================
@@ -2,7 +2,7 @@ function getSentMsgTrackerItems() {
     Hm_Ajax.request([
         {name: 'hm_ajax_hook', value: 'ajax_tiki_msg_tracker_items'},
     ], (globalRes) => {
-        if (globalRes.error) return;
+        if (globalRes.no_message) return;
         const trackerItems = unserializeResponseValue(globalRes);
 
         const [searchMarkup, searchHandler] = moveToTrackerItemSearchHandler(null, unserializeResponseValue(globalRes, 'tracker_fields'));


=====================================
lib/cypht/modules/tiki/setup.php
=====================================
@@ -281,6 +281,7 @@ return [
     'item_id' => [FILTER_SANITIZE_FULL_SPECIAL_CHARS, false],
     'field_id' => [FILTER_SANITIZE_FULL_SPECIAL_CHARS, false],
     'tracker_fields' => [FILTER_UNSAFE_RAW, FILTER_REQUIRE_ARRAY],
+    'no_message' => [FILTER_VALIDATE_BOOLEAN, false],
   ],
   'allowed_post' => [
     'imap_server_id' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,



View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/197512ae3a04be14ea1ba2a6a66656ec4c381d24

-- 
View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/197512ae3a04be14ea1ba2a6a66656ec4c381d24
You're receiving this email because of your account on gitlab.com.

_______________________________________________
TikiWiki-cvs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.