[TikiWiki-commits] [Git][tikiwiki/tiki][28.x] [FIX] Admin dashboard - Look & Feel - Layout: changed how the selected option...

"Jean-Marc Kadimba \(@jmkadimba\) via TikiWiki-cvs" <[email protected]>
Newsgroups gmane.comp.cms.tiki.cvs
Message-ID <6903115618c22_2ce1f1491418@gitlab-sidekiq-low-urgency-cpu-bound-v2-7754b588dd-9x94d.mail>

Jean-Marc Kadimba pushed to branch 28.x at Tiki Wiki CMS Groupware / Tiki


Commits:
10391896 by Jean-Marc Kadimba at 2025-10-30T09:18:44+02:00
[FIX] Admin dashboard - Look & Feel - Layout: changed how the selected option...
---
* [FIX] Admin dashboard - Look & Feel - Layout: changed how the selected option is retrieved to avoid getting a null when the field is disabled.

See merge request tikiwiki/tiki!8907


(cherry picked from commit 36073ec0a7d750bf7a3dca279a538fc0a27b4928)

afd98d18 [FIX] Admin dashboard - Look & Feel - Layout: changed how the selected option...

Co-authored-by: Jean-Marc Kadimba <[email protected]>

(cherry picked from commit ed830c1309226512a0fa2833db6c9eb7de227871)

Co-authored-by: Jean-Marc Kadimba <[email protected]>
- - - - -


1 changed file:

- admin/include_look.php


Changes:

=====================================
admin/include_look.php
=====================================
@@ -1125,9 +1125,10 @@ function edit_custom_mode(el,id,name,icon){
 
     var setupThemeLayouts = function (themeDropDown, optionDropDown, layoutDropDown) {
         themeDropDown,optionDropDown.on("change", function() {
-            var theme_name = themeDropDown.val();
-            if (optionDropDown.val()){
-                theme_name += ":" + optionDropDown.val();
+            var theme_option = optionDropDown.find("option:selected").val();
+            var theme_name = themeDropDown.find("option:selected").val();
+            if (theme_option){
+                theme_name += ":" + theme_option;
             }
             var layouts = theme_layouts[theme_name];
             var current = layoutDropDown.val();



View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/10391896a8f7514bb0543309f727af2f0f2ffc62

-- 
View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/10391896a8f7514bb0543309f727af2f0f2ffc62
You're receiving this email because of your account on gitlab.com.

_______________________________________________
TikiWiki-cvs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.