[TikiWiki-commits] [Git][tikiwiki/tiki][29.x] [ENH] ItemsList optimization when rebuilding

Victor Emanouilov pushed to branch 29.x at Tiki Wiki CMS Groupware / Tiki


Commits:
97ae65aa by Victor Emanouilov at 2025-11-25T15:31:29+02:00
[ENH] ItemsList optimization when rebuilding
---
* [ENH] ItemsList optimization when rebuilding - cache item labels and main item titles used to populate itemslist fields

See merge request tikiwiki/tiki!9115

- - - - -


2 changed files:

- lib/core/Tracker/Field/ItemsList.php
- lib/trackers/trackerlib.php


Changes:

=====================================
lib/core/Tracker/Field/ItemsList.php
=====================================
@@ -332,12 +332,12 @@ $("input[name=ins_' . $this->getOption('fieldIdHere') . '], select[name=ins_' .
         return parent::watchCompare($o, $n);    // then compare as text
     }
 
-    public function getDocumentPart(Search_Type_Factory_Interface $typeFactory)
+    public function getDocumentPart(Search_Type_Factory_Interface $typeFactory, $mode = '')
     {
         $baseKey = $this->getBaseKey();
         $items = $this->getItemIds(false);
 
-        $list = $this->getItemLabels($items);
+        $list = $this->getItemLabels($items, ['list_mode' => ''], $mode);
         $listtext = implode(' ', $list);
 
         return [
@@ -866,7 +866,7 @@ $("input[name=ins_' . $this->getOption('fieldIdHere') . '], select[name=ins_' .
      * @param array $context
      * @return array array of values by itemId
      */
-    private function getItemLabels($items, $context = ['list_mode' => ''])
+    private function getItemLabels($items, $context = ['list_mode' => ''], $mode = '')
     {
         $displayFields = $this->getOption('displayFieldIdThere');
         $trackerId = (int) $this->getOption('trackerId');
@@ -900,10 +900,11 @@ $("input[name=ins_' . $this->getOption('fieldIdHere') . '], select[name=ins_' .
                     isset($context['list_mode']) ? $context['list_mode'] : '',
                     $this->getOption('linkToItems'),
                     $this->getOption('displayFieldIdThereFormat'),
-                    $trklib->get_tracker_item($itemId)
+                    $trklib->get_tracker_item($itemId),
+                    $mode === 'indexing'
                 );
             } else {
-                $list[$itemId] = $trklib->get_isMain_value($trackerId, $itemId);
+                $list[$itemId] = $trklib->get_isMain_value($trackerId, $itemId, $mode === 'indexing');
             }
         }
 


=====================================
lib/trackers/trackerlib.php
=====================================
@@ -840,10 +840,10 @@ class TrackerLib extends TikiLib
         }
 
         $query = "
-          SELECT tiki_trackers.*, 
+          SELECT tiki_trackers.*,
           COUNT(tiki_tracker_fields.fieldId) AS fieldsCount
           FROM tiki_trackers
-          LEFT JOIN tiki_tracker_fields 
+          LEFT JOIN tiki_tracker_fields
           ON tiki_trackers.trackerId = tiki_tracker_fields.trackerId
           $join
           WHERE 1=1 $where
@@ -954,13 +954,20 @@ class TrackerLib extends TikiLib
         }
     }
 
-    public function concat_item_from_fieldslist($trackerId, $itemId, $fieldsId, $status = 'o', $separator = ' ', $list_mode = '', $strip_tags = false, $format = '', $item = [])
+    public function concat_item_from_fieldslist($trackerId, $itemId, $fieldsId, $status = 'o', $separator = ' ', $list_mode = '', $strip_tags = false, $format = '', $item = [], $use_cache = false)
     {
         $res = '';
         $values = [];
         if (is_string($fieldsId)) {
             $fieldsId = preg_split('/\|/', $fieldsId, -1, PREG_SPLIT_NO_EMPTY);
         }
+        if ($use_cache) {
+            static $cache = [];
+            $cacheKey = "concat_item_from_fieldslist_{$trackerId}_{$itemId}_{$fieldsId}_{$status}_{$separator}_{$list_mode}_{$strip_tags}_{$format}";
+            if (isset($cache[$cacheKey])) {
+                return $cache[$cacheKey];
+            }
+        }
         $definition = Tracker_Definition::get($trackerId);
         if ($definition) {
             foreach ($fieldsId as $k => $field) {
@@ -1006,6 +1013,12 @@ class TrackerLib extends TikiLib
         } else {
             Feedback::error(tr('Tracker %0 not found for Field %1', $trackerId, implode(',', $fieldsId)));
         }
+        if ($use_cache) {
+            if (TikiLib::lib('tiki')->isMemoryLow()) {
+                $cache = [];
+            }
+            $cache[$cacheKey] = $res;
+        }
         return $res;
     }
 
@@ -4169,11 +4182,16 @@ class TrackerLib extends TikiLib
      * @param [type] $trackerId, optionnal (will be retrieved from itemId if missing)
      * @param [type] $itemId
      */
-    public function get_isMain_value($trackerId, $itemId): string
+    public function get_isMain_value($trackerId, $itemId, $use_cache = false): string
     {
-        global $prefs;
-
-        $query = "SELECT tif.`value`, tf.`type` 
+        if ($use_cache) {
+            static $cache = [];
+            $cacheKey = "isMain_value_{$trackerId}_{$itemId}";
+            if (isset($cache[$cacheKey])) {
+                return $cache[$cacheKey];
+            }
+        }
+        $query = "SELECT tif.`value`, tf.`type`
                 FROM `tiki_tracker_item_fields` tif
                 JOIN `tiki_tracker_items` i ON i.`itemId` = tif.`itemId`
                 JOIN `tiki_tracker_fields` tf ON tf.`fieldId` = tif.`fieldId`
@@ -4196,7 +4214,14 @@ class TrackerLib extends TikiLib
                 $titles[] = $value;
             }
         }
-        return implode(' ', $titles);
+        $result = implode(' ', $titles);
+        if ($use_cache) {
+            if (TikiLib::lib('tiki')->isMemoryLow()) {
+                $cache = [];
+            }
+            $cache[$cacheKey] = $result;
+        }
+        return $result;
     }
     /**
      * @param int $itemId



View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/97ae65aa4051d7b4751658d35ec113a3051c4c7d

-- 
View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/97ae65aa4051d7b4751658d35ec113a3051c4c7d
You're receiving this email because of your account on gitlab.com.

_______________________________________________
TikiWiki-cvs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs