[TikiWiki-commits] [Git][tikiwiki/tiki][29.x] [BP][FIX] Correct double-encoding of '&' in URLs generated by self_link and button handlers

"luci \(@luciash\) via TikiWiki-cvs" <[email protected]>
Newsgroups gmane.comp.cms.tiki.cvs
Message-ID <6939fd723f131_2ae6ffb44599@gitlab-sidekiq-low-urgency-cpu-bound-v2-b97d68467-lktq8.mail>

luci pushed to branch 29.x at Tiki Wiki CMS Groupware / Tiki


Commits:
dc3138c9 by Yves Ngalamulume at 2025-12-10T23:00:02+00:00
[BP][FIX] Correct double-encoding of '&' in URLs generated by self_link and button handlers
---
* [FIX] Correct double-encoding of '&' in URLs generated by self_link and button handlers
---
* [FIX] Double-encoding in SelfLink by conditionally disabling _urlencode only for tag mode

* [FIX] Double-encoding in SelfLink by disabling urlencode in query

* Add clarification comment explaining href normalization logic

* [FIX] Double-encoded URLs in SelfLink (normalize href before escaping)

* [FIX] Correct double-encoding of '&'

* [FIX] Correct double-encoding of '&' in URLs generated by self_link and button handlers

See merge request tikiwiki/tiki!9113

See merge request tikiwiki/tiki!9213

- - - - -


1 changed file:

- lib/smarty_tiki/BlockHandler/SelfLink.php


Changes:

=====================================
lib/smarty_tiki/BlockHandler/SelfLink.php
=====================================
@@ -103,6 +103,9 @@ class SelfLink extends Base
 
                 $params['_type'] = $default_type;
 
+                if (! empty($params['_tag']) && $params['_tag'] === 'y') {
+                    $params['_urlencode'] = 'n';
+                }
                 $ret = smarty_function_query($params, $template);
             }
 



View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/dc3138c92c11991fda388d76b2fa939cf1f11258

-- 
View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/dc3138c92c11991fda388d76b2fa939cf1f11258
You're receiving this email because of your account on gitlab.com.

_______________________________________________
TikiWiki-cvs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.