[TikiWiki-commits] [Git][tikiwiki/tiki][29.x] Revert "[FIX] Smarty SEFURL modifier: Ensure image SEFURL is user friendly"

Victor Emanouilov pushed to branch 29.x at Tiki Wiki CMS Groupware / Tiki


Commits:
afcf97ae by Victor Emanouilov at 2025-12-16T06:40:44+02:00
Revert "[FIX] Smarty SEFURL modifier: Ensure image SEFURL is user friendly"

This reverts commit c60093f3e21cbcd19bcacbcb23193df768323cae as it is causing major regressions on SEF file links in tracker interfaces where previously non-image files used to download and now preview in the browser.

- - - - -


3 changed files:

- − installer/schema/20241107_update_right_column_for_file_type_in_sefurl_tiki.sql
- lib/smarty_tiki/Modifier/Sefurl.php
- show_image.php


Changes:

=====================================
installer/schema/20241107_update_right_column_for_file_type_in_sefurl_tiki.sql deleted
=====================================
@@ -1,3 +0,0 @@
-UPDATE `tiki_sefurl_regex_out`
-SET `right` = 'display$1'
-WHERE `type` = 'file' AND `feature` = 'feature_file_galleries';


=====================================
lib/smarty_tiki/Modifier/Sefurl.php
=====================================
@@ -84,7 +84,7 @@ class Sefurl
                 $attributes = $attributelib->get_attributes('file', $source);
 
                 if ($type == 'file') {
-                    $prefix = 'display';
+                    $prefix = 'dl';
                     $suffix = null;
                 } else {
                     $prefix = $type;


=====================================
show_image.php
=====================================
@@ -25,7 +25,7 @@ if ($prefs['feature_file_galleries'] == 'y' && $prefs['file_galleries_redirect_f
 
     if ($fileInfo) {
         include_once($tikipath . 'tiki-sefurl.php');
-        $newUrl = filter_out_sefurl('tiki-download_file.php?fileId=' . $fileInfo['itemId']);
+        $newUrl = filter_out_sefurl('tiki-download_file.php?fileId=' . $fileInfo['itemId'] . '&display');
 
         if ($tiki_p_admin === 'y') {
             Feedback::warning(tr(



View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/afcf97ae6b26a88833209689bf6422f74884ffb4

-- 
View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/afcf97ae6b26a88833209689bf6422f74884ffb4
You're receiving this email because of your account on gitlab.com.

_______________________________________________
TikiWiki-cvs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs