[TikiWiki-commits] [Git][tikiwiki/tiki][master] Make tablesorter tables appear in mPDF output (and improve mpdf_debug_output)

"Jonny Bradley \(@jonnybradley\) via TikiWiki-cvs" <[email protected]>
Newsgroups gmane.comp.cms.tiki.cvs
Message-ID <697a849d85bc2_3ba77ba0755@gitlab-sidekiq-low-urgency-cpu-bound-v2-96cd9b87c-wvg4n.mail>

Jonny Bradley pushed to branch master at Tiki Wiki CMS Groupware / Tiki


Commits:
075da344 by Jonny Bradley at 2026-01-28T21:41:43+00:00
Make tablesorter tables appear in mPDF output (and improve mpdf_debug_output)
---
* [FIX] pdf: Move the mpdf_debug_output view to temp/public and add a note on how to easily remove it

* [FIX] pdf: Set php tidy `show-body-only` option to `auto` which makes tablesorter tables work in mPDF output (not sure why)

See merge request tikiwiki/tiki!9431

- - - - -


2 changed files:

- lib/pdflib.php
- lib/prefs/print.php


Changes:

=====================================
lib/pdflib.php
=====================================
@@ -791,7 +791,7 @@ class PdfGenerator
         fwrite($tempFile, ($pagesTotal * 30));
 
         if ($prefs['print_pdf_mpdf_debug'] === 'y') {
-            file_put_contents('temp/mpdf_debug_output.html', $debugOutput);
+            file_put_contents('temp/public/mpdf_debug_output.html', $debugOutput);
         }
 
         return $mpdf->Output('', 'S');                  // Return as a string
@@ -1805,7 +1805,7 @@ function cleanHtml($html, $config = null, $encoding = 'utf8')
             'clean' => true,
             'output-xhtml' => false,
             'merge-divs' => false,
-            'show-body-only' => false,
+            'show-body-only' => 'auto',
             'new-blocklevel-tags' => 'pdfsettings pdfpage pdfinclude article aside audio bdi canvas details dialog figcaption figure footer header hgroup main menu menuitem nav section source summary template track video',
             'new-empty-tags' => 'embed keygen source track wbr',
             'new-inline-tags' => 'svg audio command datalist embed mark menuitem meter output progress source time video wbr',


=====================================
lib/prefs/print.php
=====================================
@@ -327,7 +327,8 @@ function prefs_print_list()
             'name' => tra('Debug mPDF output'),
             'description' => tra('Saves a copy of the html sent to mPDF in the temp directory'),
             'warning' => tra('Does not respect permissions, do not use with production data.'),
-            'view' => 'temp/mpdf_debug_output.html',
+            'hint' => tra('Clear the public cache to remove this and other temporary files.'),
+            'view' => 'temp/public/mpdf_debug_output.html',
             'type' => 'flag',
             'tags' => ['advanced'],
             'default' => 'n',



View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/075da344d0b5b876ad5e53c7139764081460a02b

-- 
View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/075da344d0b5b876ad5e53c7139764081460a02b
You're receiving this email because of your account on gitlab.com.

_______________________________________________
TikiWiki-cvs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.