[TikiWiki-commits] [Git][tikiwiki/tiki][master] [FIX] ignore system preferences when applying changes on preference update -...

Victor Emanouilov pushed to branch master at Tiki Wiki CMS Groupware / Tiki


Commits:
e0b09669 by Victor Emanouilov at 2026-02-10T11:03:04+02:00
[FIX] ignore system preferences when applying changes on preference update - these are forced preferences that shouldn't update the global prefs array even temporarily - this fixes, for example, the inability to move db files to filesystem when fgal_use_dir is forced via system config

- - - - -


1 changed file:

- lib/prefslib.php


Changes:

=====================================
lib/prefslib.php
=====================================
@@ -646,7 +646,7 @@ class PreferencesLib
 
     public function applyChanges($handled, $data, $limitation = null)
     {
-        global $user_overrider_prefs;
+        global $user_overrider_prefs, $systemConfiguration;
         $tikilib = TikiLib::lib('tiki');
 
         if (is_array($limitation)) {
@@ -657,6 +657,9 @@ class PreferencesLib
 
         $changes = [];
         foreach ($handled as $pref) {
+            if (isset($systemConfiguration->preference->$pref)) {
+                continue;
+            }
             if (in_array($pref, $resets)) {
                 $tikilib->delete_preference($pref);
                 $changes[$pref] = ['type' => 'reset'];



View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/e0b096690dadad464ed3cb7246b6e99bbaf5a03d

-- 
View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/e0b096690dadad464ed3cb7246b6e99bbaf5a03d
You're receiving this email because of your account on gitlab.com.

_______________________________________________
TikiWiki-cvs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs