[TikiWiki-commits] [Git][tikiwiki/tiki][27.x] [FIX] ignore system preferences when applying changes on preference update -...
"Victor Emanouilov \(@kroky\) via TikiWiki-cvs" <[email protected]>
| Newsgroups | gmane.comp.cms.tiki.cvs |
|---|---|
| Message-ID | <698af46e1d551_3b184ee41842@gitlab-sidekiq-low-urgency-cpu-bound-v2-7c66b7f6c6-6fm4m.mail> |
Victor Emanouilov pushed to branch 27.x at Tiki Wiki CMS Groupware / Tiki
Commits:
0ec2d8e5 by Victor Emanouilov at 2026-02-10T11:03:33+02:00
[FIX] ignore system preferences when applying changes on preference update - these are forced preferences that shouldn't update the global prefs array even temporarily - this fixes, for example, the inability to move db files to filesystem when fgal_use_dir is forced via system config
- - - - -
1 changed file:
- lib/prefslib.php
Changes:
=====================================
lib/prefslib.php
=====================================
@@ -649,7 +649,7 @@ class PreferencesLib
public function applyChanges($handled, $data, $limitation = null)
{
- global $user_overrider_prefs;
+ global $user_overrider_prefs, $systemConfiguration;
$tikilib = TikiLib::lib('tiki');
if (is_array($limitation)) {
@@ -660,6 +660,9 @@ class PreferencesLib
$changes = [];
foreach ($handled as $pref) {
+ if (isset($systemConfiguration->preference->$pref)) {
+ continue;
+ }
if (in_array($pref, $resets)) {
$tikilib->delete_preference($pref);
$changes[$pref] = ['type' => 'reset'];
View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/0ec2d8e55afa593e6a793d2a4d356da4c7efa18a
--
View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/0ec2d8e55afa593e6a793d2a4d356da4c7efa18a
You're receiving this email because of your account on gitlab.com.
_______________________________________________
TikiWiki-cvs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs