[TikiWiki-commits] [Git][tikiwiki/tiki][master] [FIX] Smartmenus: missing background on submenus caused by menu preview changes

"luci \(@luciash\) via TikiWiki-cvs" <[email protected]>
Newsgroups gmane.comp.cms.tiki.cvs
Message-ID <698ca26c7e0fd_3b1852549992b@gitlab-sidekiq-low-urgency-cpu-bound-v2-68c7d7f89f-fxfb2.mail>

luci pushed to branch master at Tiki Wiki CMS Groupware / Tiki


Commits:
e64103ed by Landry Bitege at 2026-02-11T15:09:31+00:00
[FIX] Smartmenus:  missing background on submenus caused by menu preview changes
---
* [FIX] Smartmenus:  missing background on submenus caused by menu preview changes

See merge request tikiwiki/tiki!9550

- - - - -


3 changed files:

- templates/bootstrap_smartmenu.tpl
- templates/bootstrap_smartmenu_children.tpl
- themes/base_files/scss/_tiki-menus.scss


Changes:

=====================================
templates/bootstrap_smartmenu.tpl
=====================================
@@ -4,11 +4,11 @@
     </li>
 {elseif not empty($item.children)}
     <li class="sm-nav-item nav-item{if $item.selected|default:null} active{/if} {$item.class|escape} {if $module_params.megamenu eq 'y' and $module_params.megamenu_static eq 'y' }static{/if}">
-        <a href="#sm_menu_{$item.optionId|escape}" class="sm-nav-link nav-link sm-sub-toggler" data-bs-toggle="collapse" aria-expanded="false">
+            <a href="{if empty($preview_type)}{$item.sefurl|escape}{else}#sm_menu_{$item.optionId|escape}{/if}" class="sm-nav-link nav-link sm-sub-toggler" data-bs-toggle="collapse" aria-expanded="false">
             {if $menu_info.use_items_icons eq "y" && $item.icon}
                 <span class="me-2">{icon name=$item.icon}</span>
             {/if}
-            <span class="mwnu-item-label me-auto">{tr}{$item.name}{/tr}</span>&nbsp;<small>{icon name="caret-down"}</small>
+            <span class="menu-item-label me-auto">{tr}{$item.name}{/tr}</span>&nbsp;<small>{icon name="caret-down"}</small>
         </a>
         {if $item.sectionLevel eq 0 and $module_params.megamenu eq 'y'}
             <ul class="sm-sub sm-sub--mega">
@@ -40,7 +40,7 @@
             {if $menu_info.use_items_icons eq "y" && $item.icon}
                 <span class="me-2">{icon name=$item.icon}</span>
             {/if}
-            <span class="mwnu-item-label me-auto">{tr}{$item.name}{/tr}</span>
+            <span class="menu-item-label me-auto">{tr}{$item.name}{/tr}</span>
         </a>
     </li>
 {/if}


=====================================
templates/bootstrap_smartmenu_children.tpl
=====================================
@@ -6,7 +6,7 @@
             {if $menu_info.use_items_icons eq "y" && $item.icon}
                 <span class="me-2">{icon name=$item.icon}</span>
             {/if}
-            <span class="mwnu-item-label me-auto">{tr}{$item.name}{/tr}</span>&nbsp;<small>{icon name="caret-down"}</small>
+            <span class="menu-item-label me-auto">{tr}{$item.name}{/tr}</span>&nbsp;<small>{icon name="caret-down"}</small>
         </a>
         <ul id="sm_submenu_{$item.optionId|escape}" class="sm-sub dropdown-menu collapse">
             {* {if $sub}


=====================================
themes/base_files/scss/_tiki-menus.scss
=====================================
@@ -203,22 +203,6 @@
     display: none;
 }
 
-.sm-sub.collapse.dropdown-menu,
-.sm-sub.collapsing.dropdown-menu {
-    border: none;
-    box-shadow: none;
-    background: transparent;
-    position: static;
-    padding-left: 1.5rem;
-}
-
-.sm-sub.collapse .dropdown-item,
-.sm-sub.collapse .sm-sub-link {
-    background: transparent;
-    border: none;
-    padding: 0.5rem 1rem;
-}
-
 .sm-sub.collapse.show {
     display: block;
 }
\ No newline at end of file



View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/e64103ed59b86bdbba8c971367c2d11514c42c61

-- 
View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/e64103ed59b86bdbba8c971367c2d11514c42c61
You're receiving this email because of your account on gitlab.com.

_______________________________________________
TikiWiki-cvs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.