[TikiWiki-commits] [Git][tikiwiki/tiki][29.x] [BP][FIX] A blank page shows up after validating user creation with a username containing a space

Adrien Mbuya Maloba pushed to branch 29.x at Tiki Wiki CMS Groupware / Tiki


Commits:
1a2e84fd by Adrien Mbuya Maloba at 2026-02-23T15:34:22+02:00
[BP][FIX] A blank page shows up after validating user creation with a username containing a space
---
* [FIX] A blank page shows up after validating user creation with a username containing a space

See merge request tikiwiki/tiki!9630

- - - - -


2 changed files:

- lib/Registration/RegistrationLib.php
- tiki-adminusers.php


Changes:

=====================================
lib/Registration/RegistrationLib.php
=====================================
@@ -267,7 +267,7 @@ class RegistrationLib extends TikiLib
             }
 
             if (! preg_match($userlib::USERNAME_MANDATORY_VALIDATION_PATTERN, $registration['name'])) {
-                return tra("Username cannot contain any spaces");
+                $errors[] = new RegistrationError('name', tra('Username cannot contain any spaces'));
             }
 
             if ($prefs['login_is_email'] != 'y') {
@@ -304,7 +304,7 @@ class RegistrationLib extends TikiLib
             }
 
             if (! preg_match($userlib::USERNAME_MANDATORY_VALIDATION_PATTERN, $registration['name'])) {
-                return tra("Username cannot contain any spaces.");
+                $errors[] = new RegistrationError('name', tra('Username cannot contain any spaces.'));
             }
 
             // Check the mode


=====================================
tiki-adminusers.php
=====================================
@@ -296,7 +296,8 @@ if (isset($_REQUEST['batch']) && is_uploaded_file($_FILES['csvlist']['tmp_name']
         $AddUser = false;
     }
     if (! preg_match($userlib::USERNAME_MANDATORY_VALIDATION_PATTERN, $_REQUEST['login'])) {
-        return tra("Username cannot contain any spaces");
+        $errors[] = tra('Username cannot contain any spaces');
+        $AddUser = false;
     }
     if ($prefs['login_is_email'] == 'y' && ! validate_email($_REQUEST['login'])) {
         $errors[] = tra('Invalid email') . ' ' . $_REQUEST['login'];



View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/1a2e84fdca6e23e6420c91aed869dc4560251531

-- 
View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/1a2e84fdca6e23e6420c91aed869dc4560251531
You're receiving this email because of your account on gitlab.com. Manage all notifications: https://gitlab.com/-/profile/notifications | Help: https://gitlab.com/help

_______________________________________________
TikiWiki-cvs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs