[TikiWiki-commits] [Git][tikiwiki/tiki][29.x] [BP][FIX] Smartmenus: missing background on submenus caused by menu preview changes

Landry Bitege pushed to branch 29.x at Tiki Wiki CMS Groupware / Tiki


Commits:
138bedbe by Landry Bitege at 2026-03-04T11:14:49+01:00
[BP][FIX] Smartmenus:  missing background on submenus caused by menu preview changes
---
* [FIX] Smartmenus:  missing background on submenus caused by menu preview changes
---
* [FIX] Smartmenus:  missing background on submenus caused by menu preview changes

See merge request tikiwiki/tiki!9550

(cherry picked from commit e64103ed59b86bdbba8c971367c2d11514c42c61)

See merge request tikiwiki/tiki!9640

- - - - -


3 changed files:

- templates/bootstrap_smartmenu.tpl
- templates/bootstrap_smartmenu_children.tpl
- themes/base_files/scss/_tiki-menus.scss


Changes:

=====================================
templates/bootstrap_smartmenu.tpl
=====================================
@@ -1,10 +1,10 @@
 {if not empty($item.children)}
     <li class="sm-nav-item nav-item{if $item.selected|default:null} active{/if} {$item.class|escape} {if $module_params.megamenu eq 'y' and $module_params.megamenu_static eq 'y' }static{/if}">
-        <a href="#sm_menu_{$item.optionId|escape}" class="sm-nav-link nav-link sm-sub-toggler" data-bs-toggle="collapse" aria-expanded="false">
+            <a href="{if empty($preview_type)}{$item.sefurl|escape}{else}#sm_menu_{$item.optionId|escape}{/if}" class="sm-nav-link nav-link sm-sub-toggler" data-bs-toggle="collapse" aria-expanded="false">
             {if $menu_info.use_items_icons eq "y" && $item.icon}
                 <span class="me-2">{icon name=$item.icon}</span>
             {/if}
-            <span class="mwnu-item-label me-auto">{tr}{$item.name}{/tr}</span>&nbsp;<small>{icon name="caret-down"}</small>
+            <span class="menu-item-label me-auto">{tr}{$item.name}{/tr}</span>&nbsp;<small>{icon name="caret-down"}</small>
         </a>
         {if $item.sectionLevel eq 0 and $module_params.megamenu eq 'y'}
             <ul class="sm-sub sm-sub--mega">
@@ -36,7 +36,7 @@
             {if $menu_info.use_items_icons eq "y" && $item.icon}
                 <span class="me-2">{icon name=$item.icon}</span>
             {/if}
-            <span class="mwnu-item-label me-auto">{tr}{$item.name}{/tr}</span>
+            <span class="menu-item-label me-auto">{tr}{$item.name}{/tr}</span>
         </a>
     </li>
 {/if}


=====================================
templates/bootstrap_smartmenu_children.tpl
=====================================
@@ -4,7 +4,7 @@
             {if $menu_info.use_items_icons eq "y" && $item.icon}
                 <span class="me-2">{icon name=$item.icon}</span>
             {/if}
-            <span class="mwnu-item-label me-auto">{tr}{$item.name}{/tr}</span>&nbsp;<small>{icon name="caret-down"}</small>
+            <span class="menu-item-label me-auto">{tr}{$item.name}{/tr}</span>&nbsp;<small>{icon name="caret-down"}</small>
         </a>
         <ul id="sm_submenu_{$item.optionId|escape}" class="sm-sub dropdown-menu collapse">
             {* {if $sub}


=====================================
themes/base_files/scss/_tiki-menus.scss
=====================================
@@ -210,22 +210,6 @@
     display: none;
 }
 
-.sm-sub.collapse.dropdown-menu,
-.sm-sub.collapsing.dropdown-menu {
-    border: none;
-    box-shadow: none;
-    background: transparent;
-    position: static;
-    padding-left: 1.5rem;
-}
-
-.sm-sub.collapse .dropdown-item,
-.sm-sub.collapse .sm-sub-link {
-    background: transparent;
-    border: none;
-    padding: 0.5rem 1rem;
-}
-
 .sm-sub.collapse.show {
     display: block;
 }
\ No newline at end of file



View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/138bedbe35f7089cdd7eedd098ad6d0ee69bfc3f

-- 
View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/138bedbe35f7089cdd7eedd098ad6d0ee69bfc3f
You're receiving this email because of your account on gitlab.com. Manage all notifications: https://gitlab.com/-/profile/notifications | Help: https://gitlab.com/help

_______________________________________________
TikiWiki-cvs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs