[TikiWiki-commits] [Git][tikiwiki/tiki][master] [FIX] param: Ensure 'name' parameter is required because the plugin does...
"Jonny Bradley \(@jonnybradley\) via TikiWiki-cvs" <[email protected]>
| Newsgroups | gmane.comp.cms.tiki.cvs |
|---|---|
| Message-ID | <69beaf85839c9_3b18d9188b2@gitlab-sidekiq-low-urgency-cpu-bound-v2-b8bcfc565-dzql6.mail> |
Jonny Bradley pushed to branch master at Tiki Wiki CMS Groupware / Tiki
Commits:
151ebe04 by jonnybradley at 2026-03-21T14:47:14+00:00
[FIX] param: Ensure 'name' parameter is required because the plugin does nothing if the name is not specified
Partial revert of !8616 - no need to preserve buggy and senseless behaviour (imho)
- - - - -
1 changed file:
- lib/wiki-plugins/wikiplugin_param.php
Changes:
=====================================
lib/wiki-plugins/wikiplugin_param.php
=====================================
@@ -18,7 +18,7 @@ function wikiplugin_param_info()
'introduced' => 7,
'params' => [
'name' => [
- 'required' => false,
+ 'required' => true,
'name' => tra('Name'),
'description' => tr('Names of parameters required to display text, separated by %0|%1.', '<code>', '</code>'),
'since' => '7.0',
@@ -70,7 +70,6 @@ function wikiplugin_param($data, $params)
$params['source'] = 'request';
}
- $params['name'] = ! is_null($params['name']) ? $params['name'] : [];
foreach ($params['name'] as $name) {
$value = null;
switch ($params['source']) {
View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/151ebe04edec2c4911c5c455cdb3d0dfd93ccf77
--
View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/151ebe04edec2c4911c5c455cdb3d0dfd93ccf77
You're receiving this email because of your account on gitlab.com. Manage all notifications: https://gitlab.com/-/profile/notifications | Help: https://gitlab.com/help
_______________________________________________
TikiWiki-cvs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs