[TikiWiki-commits] [Git][tikiwiki/tiki][master] [FIX] Module: order property override and rows property reset issues

"Adrien Mbuya Maloba \(@adrienmaloba\) via TikiWiki-cvs" <[email protected]>
Newsgroups gmane.comp.cms.tiki.cvs
Message-ID <69c69d813f10d_3b18f13c3085a@gitlab-sidekiq-low-urgency-cpu-bound-v2-5865484f5c-t9xzx.mail>

Adrien Mbuya Maloba pushed to branch master at Tiki Wiki CMS Groupware / Tiki


Commits:
63cda6c8 by Landry Bitege at 2026-03-27T17:00:48+02:00
[FIX] Module: order property override and rows property reset issues
---
* [FIX] Module: order property override and rows property reset issues

See merge request tikiwiki/tiki!9775

- - - - -


1 changed file:

- tiki-admin_modules.php


Changes:

=====================================
tiki-admin_modules.php
=====================================
@@ -127,6 +127,7 @@ if (! empty($_REQUEST['edit_assign'])) {
     $smarty->assign_by_ref('assign_position', $info['position']);
     $smarty->assign_by_ref('assign_cache', $info['cache_time']);
     $smarty->assign_by_ref('assign_type', $info['type']);
+    $smarty->assign_by_ref('assign_rows', $info['rows']);
     $smarty->assign_by_ref('assign_order', $cosa);
     $smarty->assign_by_ref('info', $info);
     if (! $info['name']) {
@@ -152,6 +153,7 @@ if (! empty($_REQUEST['edit_assign'])) {
             parse_str($info['params'], $params);
         }
     }
+    $params['rows'] = $info['rows'];
 
     $modlib->dispatchValues($params, $modinfo['params']);
     $smarty->assign('assign_info', $modinfo);
@@ -413,7 +415,6 @@ if (isset($_REQUEST['assign']) && $access->checkCsrf()) {
             $_REQUEST['assign_type']
         );
         $logslib->add_log('adminmodules', 'assigned module ' . $assign_name);
-        $modlib->reorder_modules();
         if ($result) {
             Feedback::success(tr('Module assigned'));
         } else {



View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/63cda6c86774c0a05b92768556309464e90e63da

-- 
View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/63cda6c86774c0a05b92768556309464e90e63da
You're receiving this email because of your account on gitlab.com. Manage all notifications: https://gitlab.com/-/profile/notifications | Help: https://gitlab.com/help

_______________________________________________
TikiWiki-cvs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.