[TikiWiki-commits] [Git][tikiwiki/tiki][24.x] [BP] Login from cookie again

"Jonny Bradley \(@jonnybradley\) via TikiWiki-cvs" <[email protected]>
Newsgroups gmane.comp.cms.tiki.cvs
Message-ID <69d642236fff_3b19102c96023@gitlab-sidekiq-low-urgency-cpu-bound-v2-56795c899f-k4wmg.mail>

Jonny Bradley pushed to branch 24.x at Tiki Wiki CMS Groupware / Tiki


Commits:
7e24f322 by luci at 2026-04-08T11:48:40+00:00
[BP] Login from cookie again
---
* Login from cookie again
---
* [FIX] login: Cast the userId to a string to compare with the value retrieved from the cookie

See merge request tikiwiki/tiki!7509


(cherry picked from commit ed0bca2458f6bfc29cff74ddebfe6a0a7a476ee8)

3283133f [FIX] login: Cast the userId to a string to compare with the value retrieved from the cookie

Co-authored-by: Jonny Bradley <[email protected]>

(cherry picked from commit 0352429f7c43f43915890c5e652c0a9c490e13e4)

Co-authored-by: Jonny Bradley <[email protected]>

(cherry picked from commit f8fd9bc706a07e792e3f607abffa7310e865b8c4)

Co-authored-by: Jonny Bradley <[email protected]>

See merge request tikiwiki/tiki!9929

- - - - -


1 changed file:

- lib/userslib.php


Changes:

=====================================
lib/userslib.php
=====================================
@@ -7240,7 +7240,7 @@ class UsersLib extends TikiLib
         list($secret, $userId) = explode('.', $cookie, 2);
         $query = 'select `userId` from `tiki_user_login_cookies` where `secret`=? and `userId`=? and `expiration` > NOW()';
 
-        if ($userId === $this->getOne($query, [$secret, $userId])) {
+        if ($userId === (string) $this->getOne($query, [$secret, $userId])) {
             return $userId;
         } else {
             TikiLib::lib('logs')->add_log('login', 'get_user_by_cookie failed', $userId);



View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/7e24f3227e2736f18450413ca00ec20bad99cadd

-- 
View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/7e24f3227e2736f18450413ca00ec20bad99cadd
You're receiving this email because of your account on gitlab.com. Manage all notifications: https://gitlab.com/-/profile/notifications | Help: https://gitlab.com/help

_______________________________________________
TikiWiki-cvs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.