[TikiWiki-commits] [Git][tikiwiki/tiki][30.x] [FIX][UI] My misplaced div closing tag in MR 9815 caused commments to go...

"Gary Cunningham-Lee \(--- via TikiWiki-cvs" <[email protected]>
Newsgroups gmane.comp.cms.tiki.cvs
Message-ID <69e2024a9d93f_3b18ee44423ae@gitlab-sidekiq-low-urgency-cpu-bound-v2-54f6575767-7tphd.mail>

Gary Cunningham-Lee pushed to branch 30.x at Tiki Wiki CMS Groupware / Tiki


Commits:
bca412bb by Gary Cunningham-Lee at 2026-04-17T18:42:39+09:00
[FIX][UI] My misplaced div closing tag in MR 9815 caused commments to go...
---
* [FIX][UI] My misplaced div closing tag in MR 9815 caused commments to go...
---
* [FIX][UI] My misplaced div closing tag in MR 9815 caused commments to go sideways - literally. Thanks, luci.

See merge request tikiwiki/tiki!10034


(cherry picked from commit 41529617379b5004c56b5afc7beedc4a801a92aa)

1e2aaac9 [FIX][UI] My misplaced div closing tag in MR 9815 caused commments to go...

Co-authored-by: Gary Cunningham-Lee <gary_c-39LOpZwlz1/[email protected]>

See merge request tikiwiki/tiki!10035

- - - - -


1 changed file:

- templates/comment/list_inner.tpl


Changes:

=====================================
templates/comment/list_inner.tpl
=====================================
@@ -65,25 +65,26 @@
                         {/if}
                         {if $comment.userName ne $user and $comment.approved eq 'y' and $allow_vote}
                             <div class="commentRating d-inline-block ms-3">
-                            <form class="commentRatingForm" method="post">
-                                <fieldset>
-                                    <legend class="fs-6">{tr}Rate this comment:{/tr}</legend>
-                                    {rating type="comment" id=$comment.threadId}
-                                    <input type="hidden" name="id" value="{$comment.threadId}" />
-                                    <input type="hidden" name="type" value="comment" />
-                                </fieldset>
-                            </form>
-                            {jq}
-                                var crf = $('form.commentRatingForm').on("submit", function() {
-                                    var vals = $(this).serialize();
-                                    $.tikiModal(tr('Loading...'));
-                                    $.post($.service('rating', 'vote'), vals, function() {
-                                        $.tikiModal();
-                                        showMessage(tr('Thanks for rating!'), "success");
+                                <form class="commentRatingForm" method="post">
+                                    <fieldset>
+                                        <legend class="fs-6">{tr}Rate this comment:{/tr}</legend>
+                                        {rating type="comment" id=$comment.threadId}
+                                        <input type="hidden" name="id" value="{$comment.threadId}" />
+                                        <input type="hidden" name="type" value="comment" />
+                                    </fieldset>
+                                </form>
+                                {jq}
+                                    var crf = $('form.commentRatingForm').on("submit", function() {
+                                        var vals = $(this).serialize();
+                                        $.tikiModal(tr('Loading...'));
+                                        $.post($.service('rating', 'vote'), vals, function() {
+                                            $.tikiModal();
+                                            showMessage(tr('Thanks for rating!'), "success");
+                                        });
+                                        return false;
                                     });
-                                    return false;
-                                });
-                            {/jq}
+                                {/jq}
+                            </div>
                         {/if}
                         {if $prefs.wiki_comments_simple_ratings eq 'y' && ($tiki_p_ratings_view_results eq 'y' or $tiki_p_admin eq 'y')}
                             {rating_result type="comment" id=$comment.threadId}
@@ -106,7 +107,6 @@
                                 </div>
                             </div>
                         {/if}
-                            </div>
                     </div>{* End of comment-footer *}
                 </div>{* End of comment-item *}
                 {if ! $level || $prefs.comments_threshold_indent eq '0' || $level lt $prefs.comments_threshold_indent}



View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/bca412bb395b448ddc2b2ddbbe4716ce830ddf45

-- 
View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/bca412bb395b448ddc2b2ddbbe4716ce830ddf45
You're receiving this email because of your account on gitlab.com. Manage all notifications: https://gitlab.com/-/profile/notifications | Help: https://gitlab.com/help

_______________________________________________
TikiWiki-cvs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.