[TikiWiki-commits] [Git][tikiwiki/tiki][master] [ENH] Add end time support to YouTube plugin

luci pushed to branch master at Tiki Wiki CMS Groupware / Tiki


Commits:
bc126859 by Olivier Kango at 2026-05-21T08:26:36+00:00
[ENH] Add end time support to YouTube plugin
---
* Add since metadata to YouTube end parameter

* Add since metadata to YouTube time parameters

* [ENH] Add end time support to YouTube plugin

* [ENH] Add end time support to YouTube plugin

See merge request tikiwiki/tiki!10243

- - - - -


3 changed files:

- lib/test/wiki-plugins/YoutubeTest.php
- lib/wiki-plugins/shared/embed_helpers.php
- lib/wiki-plugins/wikiplugin_youtube.php


Changes:

=====================================
lib/test/wiki-plugins/YoutubeTest.php
=====================================
@@ -63,6 +63,11 @@ class WikiPlugin_YoutubeTest extends PHPUnit\Framework\TestCase
                 'movie'           => 'https://www.youtube.com/watch?v=4AcGoG9PChs',
                 'privacyEnhanced' => 'n',
             ]],
+            ['', 'start=12&end=34', [
+                'movie' => 'https://www.youtube.com/watch?v=4AcGoG9PChs',
+                'start' => 12,
+                'end'   => 34,
+            ]],
 
             // All supported YouTube URL formats
             ['', 'youtube-nocookie.com/embed/j4dMnAPZu70', ['movie' => 'https://youtu.be/j4dMnAPZu70']],


=====================================
lib/wiki-plugins/shared/embed_helpers.php
=====================================
@@ -69,8 +69,10 @@ function buildEmbedContainerAndIframe($iframeSrc, $params = [], $oEmbedData = []
     $containerStyle = implode(';', array_map(fn($k, $v) => "$k:$v", array_keys($containerStyles), $containerStyles));
     $iframeStyle = implode(';', array_map(fn($k, $v) => "$k:$v", array_keys($iframeStyles), $iframeStyles));
 
-    if (! empty($params['start']) && is_numeric($params['start']) && $params['start'] > 0) {
-        $iframeSrc .= (strpos($iframeSrc, '?') === false ? '?' : '&') . 'start=' . $params['start'];
+    foreach (['start', 'end'] as $timeParam) {
+        if (! empty($params[$timeParam]) && is_numeric($params[$timeParam]) && $params[$timeParam] > 0) {
+            $iframeSrc .= (strpos($iframeSrc, '?') === false ? '?' : '&') . $timeParam . '=' . (int) $params[$timeParam];
+        }
     }
 
     $dom = new DOMDocument();


=====================================
lib/wiki-plugins/wikiplugin_youtube.php
=====================================
@@ -60,6 +60,14 @@ function wikiplugin_youtube_info()
                 'filter' => 'digits',
                 'default' => 0,
             ],
+            'end' => [
+                'required' => false,
+                'name' => tra('End time'),
+                'description' => tra('End time offset in seconds'),
+                'since' => '30.1',
+                'filter' => 'digits',
+                'default' => 0,
+            ],
             'quality' => [
                 'required' => false,
                 'name' => tra('Quality'),



View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/bc126859b41bc096b27fc1d3113a320abb349268

-- 
View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/bc126859b41bc096b27fc1d3113a320abb349268
You're receiving this email because of your account on gitlab.com. Manage all notifications: https://gitlab.com/-/profile/notifications | Help: https://gitlab.com/help

_______________________________________________
TikiWiki-cvs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs