[TikiWiki-commits] [Git][tikiwiki/tiki][master] [FIX] Must Read: Restore the feature in new Tiki version

"Domeshow Emmanuel \(@Domeshow\) via TikiWiki-cvs" <[email protected]>
Newsgroups gmane.comp.cms.tiki.cvs
Message-ID <6a157554d214d_382f4154488733@gitlab-sidekiq-low-urgency-cpu-bound-v2-5bd7895658-9v9pw.mail>

Domeshow Emmanuel pushed to branch master at Tiki Wiki CMS Groupware / Tiki


Commits:
70bd7713 by Domeshow Emmanuel at 2026-05-26T13:09:03+03:00
[FIX] Must Read: Restore the feature in new Tiki version
---
* [FIX] Must Read: Restore the feature in new Tiki version

See merge request tikiwiki/tiki!10373

- - - - -


3 changed files:

- lib/core/Services/Comment/Controller.php
- lib/core/Services/MustRead/Controller.php
- templates/mustread/list.tpl


Changes:

=====================================
lib/core/Services/Comment/Controller.php
=====================================
@@ -33,7 +33,7 @@ class Services_Comment_Controller
 
         $objectlib = TikiLib::lib('object');
         try {
-            if ($objectId !== $input->objectId->none() || ! $objectlib->isValidObject($type, $objectId)) {
+            if ($objectId != $input->objectId->none() || ! $objectlib->isValidObject($type, $objectId)) {
                 $objectId = $input->objectId->xss();
                 throw new Services_Exception(tr('Invalid %0 ID: %1', $type, $objectId), 403);
             }


=====================================
lib/core/Services/MustRead/Controller.php
=====================================
@@ -35,7 +35,7 @@ class Services_MustRead_Controller
 
         return [
             'title' => tr('Must Read'),
-            'list' => $result,
+            'listMR' => $result,
             'canAdd' => Tracker_Item::newItem($prefs['mustread_tracker'])->canModify(),
             'selection' => $selection ? $selection->getId() : null,
             'notification' => $input->notification->word(),


=====================================
templates/mustread/list.tpl
=====================================
@@ -17,7 +17,7 @@
                 <th>{tr}Action Req'd{/tr}</th>
                 <th>{tr}Complete{/tr}</th>
             </tr>
-            {foreach $list as $entry}
+            {foreach $listMR as $entry}
                 <tr {if $selection eq $entry.object_id}class="active"{/if}>
                     <td><a href="{service controller=mustread action=list id=$entry.object_id}">{$entry.title|escape}</a></td>
                     <td>{$entry.creation_date|tiki_short_datetime}</td>



View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/70bd7713ac03a4c18f5e514b85239d3f0e337472

-- 
View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/70bd7713ac03a4c18f5e514b85239d3f0e337472
You're receiving this email because of your account on gitlab.com. Manage all notifications: https://gitlab.com/-/profile/notifications | Help: https://gitlab.com/help

_______________________________________________
TikiWiki-cvs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.