[TikiWiki-commits] [Git][tikiwiki/tiki][29.x] [FIX] Must Read: Restore the feature in new Tiki version

Domeshow Emmanuel pushed to branch 29.x at Tiki Wiki CMS Groupware / Tiki


Commits:
51fa2b67 by Domeshow Emmanuel at 2026-05-26T23:29:19+03:00
[FIX] Must Read: Restore the feature in new Tiki version
---
* [FIX] Must Read: Restore the feature in new Tiki version
---
* [FIX] Must Read: Restore the feature in new Tiki version

See merge request tikiwiki/tiki!10374


(cherry picked from commit 2964ff643ae7fbfe730249ed37ba66f1ad4314a4)

83601d01 [FIX] Must Read: Restore the feature in new Tiki version

Co-authored-by: Domeshow Emmanuel <[email protected]>

See merge request tikiwiki/tiki!10378

- - - - -


3 changed files:

- lib/core/Services/Comment/Controller.php
- lib/core/Services/MustRead/Controller.php
- templates/mustread/list.tpl


Changes:

=====================================
lib/core/Services/Comment/Controller.php
=====================================
@@ -31,7 +31,7 @@ class Services_Comment_Controller
         }
 
         $objectlib = TikiLib::lib('object');
-        if ($objectId !== $input->objectId->none() || ! $objectlib->isValidObject($type, $objectId)) {
+        if ($objectId != $input->objectId->none() || ! $objectlib->isValidObject($type, $objectId)) {
             $objectId = $input->objectId->xss();
             throw new Services_Exception(tr('Invalid %0 ID: %1', $type, $objectId), 403);
         }


=====================================
lib/core/Services/MustRead/Controller.php
=====================================
@@ -35,7 +35,7 @@ class Services_MustRead_Controller
 
         return [
             'title' => tr('Must Read'),
-            'list' => $result,
+            'listMR' => $result,
             'canAdd' => Tracker_Item::newItem($prefs['mustread_tracker'])->canModify(),
             'selection' => $selection ? $selection->getId() : null,
             'notification' => $input->notification->word(),


=====================================
templates/mustread/list.tpl
=====================================
@@ -17,7 +17,7 @@
                 <th>{tr}Action Req'd{/tr}</th>
                 <th>{tr}Complete{/tr}</th>
             </tr>
-            {foreach $list as $entry}
+            {foreach $listMR as $entry}
                 <tr {if $selection eq $entry.object_id}class="active"{/if}>
                     <td><a href="{service controller=mustread action=list id=$entry.object_id}">{$entry.title|escape}</a></td>
                     <td>{$entry.creation_date|tiki_short_datetime}</td>



View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/51fa2b6715097ce20d24b0fd5dd4fcf8c5dcfaae

-- 
View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/51fa2b6715097ce20d24b0fd5dd4fcf8c5dcfaae
You're receiving this email because of your account on gitlab.com. Manage all notifications: https://gitlab.com/-/profile/notifications | Help: https://gitlab.com/help

_______________________________________________
TikiWiki-cvs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs